| Summary: | Avatars interface doesn't implement D-Bus properties | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Felix Kerekes <sttwister> |
| Component: | haze | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | CC: | will |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/smcv/haze-smcv.git;a=shortlog;h=refs/heads/avatars | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
|
Description
Felix Kerekes
2009-06-15 14:16:57 UTC
Here, have a patch. One thing I'm slightly unsure about is that haze_connection_avatars_properties_getter can be called before the Connection is CONNECTED. Is it safe for it to assume that the account's prpl_info will be present already? Looks fine. Does it work? Is there a simple smoke-test in Gabble we could steal? (In reply to comment #2) > Looks fine. Does it work? Is there a simple smoke-test in Gabble we could > steal? Good idea. I stole the one from Gabble and adjusted it to also try before connecting. (In reply to comment #1) > One thing I'm slightly unsure about is that > haze_connection_avatars_properties_getter can be called before the Connection > is CONNECTED. Is it safe for it to assume that the account's prpl_info will be > present already? It turns out this wasn't safe, and crashed Haze. Fixed in my revised branch by returning dummy values before CONNECTED (the spec allows this). (In reply to comment #3) > (In reply to comment #2) > > Looks fine. Does it work? Is there a simple smoke-test in Gabble we could > > steal? > > Good idea. I stole the one from Gabble and adjusted it to also try before > connecting. Could the adjustment be merged back to Gabble too? > (In reply to comment #1) > > One thing I'm slightly unsure about is that > > haze_connection_avatars_properties_getter can be called before the Connection > > is CONNECTED. Is it safe for it to assume that the account's prpl_info will be > > present already? > > It turns out this wasn't safe, and crashed Haze. Fixed in my revised branch by > returning dummy values before CONNECTED (the spec allows this). Good catch. Fixed in git for 0.3.5. (In reply to comment #4) > Could the adjustment be merged back to Gabble too? Yes, in progress. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.