| Summary: | [regression OGLC] 7 cases failed | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Shuang He <shuang.he> |
| Component: | Drivers/DRI/i915 | Assignee: | Ian Romanick <idr> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | brian.paul |
| Version: | git | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Shuang He
2009-06-17 22:53:03 UTC
The problem with this commit is that some of the constants, such as 4294967295.0 and 2147483647.0, have mantissas that are too large to fit in a 32-bit float. I suspect removing the "F" from the instances of those values will eliminate the problems in the pixel transfer paths. I went a head and pushed a fix for this. If Jose wants to do something different here, I'm fine with that. I can't find his bugzilla account, so I can't CC him. Brian, can you ping him? commit 70e72070fce6aa1e0918dcc62c1949465cee69f7 Author: Ian Romanick <ian.d.romanick@intel.com> Date: Mon Jun 22 18:22:51 2009 -0700 mesa: From float type modifier from values to large for singles The values 2147483648.0 and 4294967294.0 are too larget to be stored in sing precision floats. Forcing these to be singles causes bits to be lost, which results in errors in some pixel transfer tests. This fixes bug #22344. verified against following configuration on Q35: mesa: (master) 70e72070fce6aa1e0918dcc62c1949465cee69f7 Mass version move, cvs -> git |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.