Bug 2254

Summary: Build failure with gcc4.00
Product: xprint Reporter: Roland Mainz <roland.mainz>
Component: Server: OtherAssignee: Roland Mainz <roland.mainz>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: high CC: dparsons, eich
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 2008    
Attachments:
Description Flags
[FIXED_X11R68x] Patch for 2005-01-10-trunk
roland.mainz: 6.8-branch+
[FIXED_X11R68x] Refix for 2005-01-10-trunk to get rid of |ExecCommand()| roland.mainz: 6.8-branch+

Description Roland Mainz 2005-01-10 06:04:14 UTC
[Originally reported in the SuSE bugzilla]
Xprt doesn't build with gcc4.00 due various errors. patch follows.
Comment 1 Roland Mainz 2005-01-10 06:14:02 UTC
Created attachment 1654 [details] [review]
[FIXED_X11R68x] Patch for 2005-01-10-trunk
Comment 2 Roland Mainz 2005-01-10 06:18:45 UTC
Patch checked-in into Xorg trunk...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.656; previous revision: 1.655
/cvs/xorg/xc/programs/Xserver/Xprint/Util.c,v  <--  Util.c
new revision: 1.3; previous revision: 1.2
/cvs/xorg/xc/programs/Xserver/Xprint/attributes.h,v  <--  attributes.h
new revision: 1.3; previous revision: 1.2
/cvs/xorg/xc/programs/Xserver/Xprint/ps/Ps.h,v  <--  Ps.h
new revision: 1.6; previous revision: 1.5
Mailing the commit message to xorg-commit@lists.freedesktop.org...

... marking bug as FIXED (please reopen if I missed any issue, I don't have
gcc4.0 installed for testing yet... ;-( ).
Comment 3 Roland Mainz 2005-01-10 06:19:49 UTC
Comment on attachment 1654 [details] [review]
[FIXED_X11R68x] Patch for 2005-01-10-trunk

Requesting approval for X11R6.8.x stable branch - the patch is a pure build
failure fix to make gcc4.0 happy.
Comment 4 Roland Mainz 2005-01-10 10:27:41 UTC
Reopening bug per comments from the 2005-01-10 Xorg release wranglers phone
call. Egbert is right - the |ExecCommand()| function should go away completely
as there is no consumer for this function.
Comment 5 Roland Mainz 2005-01-10 10:38:21 UTC
Created attachment 1659 [details] [review]
[FIXED_X11R68x] Refix for 2005-01-10-trunk to get rid of |ExecCommand()|
Comment 6 Roland Mainz 2005-01-10 10:49:05 UTC
attachment #1659 [details] [review] checked-in into Xorg trunk...

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.660; previous revision: 1.659
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/Xprint/attributes.c,v  <--  attributes.c
new revision: 1.8; previous revision: 1.7
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...

... marking bug as FIXED again.
Comment 7 Roland Mainz 2005-01-10 10:53:21 UTC
Comment on attachment 1659 [details] [review]
[FIXED_X11R68x] Refix for 2005-01-10-trunk to get rid of |ExecCommand()|

Requesting approval for X11R6.8.x stable branch, the patch fixes the issue
outlined by Egbert Eich in the release-wranglers 2005-01-10 phone call.
Comment 8 Roland Mainz 2005-01-23 19:31:22 UTC
Comment on attachment 1654 [details] [review]
[FIXED_X11R68x] Patch for 2005-01-10-trunk

Patch approved for commit into X11R6.8.x stable branch in the 2005-01-14
release-wranglers phone call.
Comment 9 Roland Mainz 2005-01-23 19:31:41 UTC
Comment on attachment 1659 [details] [review]
[FIXED_X11R68x] Refix for 2005-01-10-trunk to get rid of |ExecCommand()|

Patch approved for commit into X11R6.8.x stable branch in the 2005-01-14
release-wranglers phone call.
Comment 10 Roland Mainz 2005-01-23 19:40:48 UTC
attachment #1654 [details] [review] and attachment #1659 [details] [review] checked-in into X11R6.8.x stable branch
(both patches in one single commit).

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.129; previous revision: 1.365.2.128
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/Xprint/Util.c,v  <--  Util.c
new revision: 1.2.4.1; previous revision: 1.2
/cvs/xorg/xc/programs/Xserver/Xprint/attributes.c,v  <--  attributes.c
new revision: 1.5.4.3; previous revision: 1.5.4.2
/cvs/xorg/xc/programs/Xserver/Xprint/attributes.h,v  <--  attributes.h
new revision: 1.2.4.1; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/Xprint/ps/Ps.h,v  <--  Ps.h
new revision: 1.3.4.3; previous revision: 1.3.4.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.