Bug 22547

Summary: [xserver 1.6.1.902] duplicate entries in Makefile.am causing make install to fail
Product: xorg Reporter: Arkadiusz Miskiewicz <arekm>
Component: Build/ModularAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium CC: pebender
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
patch fixing the issue by removing duplicates
none
git formatted patch none

Description Arkadiusz Miskiewicz 2009-06-29 23:42:28 UTC 
Created attachment 27247 [details] [review]
patch fixing the issue by removing duplicates

There are some Makefile.am with duplicate (to be installed at make install) files specified which cause failure like:

make[5]: Entering directory `/home/users/arekm/rpm/BUILD/xorg-server-1.6.1.902/hw/xfree86/parser'                                                            
test -z "/usr/lib64" || /bin/mkdir -p "/home/users/arekm/tmp/xorg-xserver-server-1.6.1.902-root-arekm/usr/lib64"                                             
test -z "/usr/include/xorg" || /bin/mkdir -p "/home/users/arekm/tmp/xorg-xserver-server-1.6.1.902-root-arekm/usr/include/xorg"                               
 /usr/bin/install -c -m 644  libxf86config.a '/home/users/arekm/tmp/xorg-xserver-server-1.6.1.902-root-arekm/usr/lib64'                                      
 /usr/bin/install -c -m 644 xf86Optrec.h xf86Parser.h xf86Parser.h xf86Optrec.h '/home/users/arekm/tmp/xorg-xserver-server-1.6.1.902-root-arekm/usr/include/xorg'                                                                                                                                                         
/usr/bin/install: will not overwrite just-created `/home/users/arekm/tmp/xorg-xserver-server-1.6.1.902-root-arekm/usr/include/xorg/xf86Parser.h' with `xf86Parser.h'                                                                                                                                                      
/usr/bin/install: will not overwrite just-created `/home/users/arekm/tmp/xorg-xserver-server-1.6.1.902-root-arekm/usr/include/xorg/xf86Optrec.h' with `xf86Optrec.h'                                                                                                                                                      
make[5]: *** [install-sdkHEADERS] Error 1
make[5]: *** Waiting for unfinished jobs....
Comment 1 Julien Cristau 2009-07-01 06:48:59 UTC 
*** Bug 22565 has been marked as a duplicate of this bug. ***
Comment 2 Rémi Cardona 2009-07-03 02:28:43 UTC 
Created attachment 27363 [details] [review]
git formatted patch

Same patch as attachment 27247 [details] [review] but git formatted.

Works For Me (tm) and I'm shipping it in Gentoo's 1.6.1.902 for further testing.

Thanks
Comment 3 Arkadiusz Miskiewicz 2009-07-03 02:48:50 UTC 
http://bugs.freedesktop.org/attachment.cgi?id=27278 patch also moved xf86xvpriv.h into "if XV" area which also makes sense I guess (but it's separate issue)
Comment 4 Rémi Cardona 2009-07-03 05:22:04 UTC 
Which bug is that?
Comment 5 Arkadiusz Miskiewicz 2009-07-03 05:34:27 UTC 
Bug 22565
Comment 6 Paul Bender 2009-07-03 06:52:18 UTC 
(In reply to comment #3)
> http://bugs.freedesktop.org/attachment.cgi?id=27278 patch also moved
> xf86xvpriv.h into "if XV" area which also makes sense I guess (but it's
> separate issue)

You are right. The reason that they are combined into one is that I pulled it from git master b1dac41fb3853ca8182048ea57b88b6e84ecceb3, which has them combined into one.
Comment 7 Arkadiusz Miskiewicz 2009-09-07 01:49:21 UTC 
Fixed in c859b736d1d23c5dc2f53958b1e76660e6d45018.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.