Bug 22637

Summary: xv brightness/contrast broken
Product: xorg Reporter: Paulo Dias <paulo.miguel.dias>
Component: Driver/RadeonAssignee: xf86-video-ati maintainers <xorg-driver-ati>
Status: RESOLVED NOTABUG QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Paulo Dias 2009-07-06 11:01:40 UTC
with latest mesa/ddx/drm , although i get brightness/contrast appearing in xvinfo:

X-Video Extension version 2.2                                                                                                                  
screen #0                                                                                                                                      
  Adaptor #0: "Radeon Textured Video"                                                                                                          
    number of ports: 16                                                                                                                        
    port base: 57                                                                                                                              
    operations supported: PutImage                                                                                                             
    supported visuals:                                                                                                                         
      depth 24, visualID 0x21                                                                                                                  
    number of attributes: 8                                                                                                                    
      "XV_BICUBIC" (range 0 to 2)                                                                                                              
              client settable attribute                                                                                                        
              client gettable attribute (current value is 2)                                                                                   
      "XV_VSYNC" (range 0 to 1)                                                                                                                
              client settable attribute                                                                                                        
              client gettable attribute (current value is 1)                                                                                   
      "XV_BRIGHTNESS" (range -1000 to 1000)                                                                                                    
              client settable attribute
              client gettable attribute (current value is 0)
      "XV_CONTRAST" (range -1000 to 1000)
              client settable attribute
              client gettable attribute (current value is 0)
      "XV_SATURATION" (range -1000 to 1000)
              client settable attribute
              client gettable attribute (current value is 0)
      "XV_HUE" (range -1000 to 1000)
              client settable attribute
              client gettable attribute (current value is 0)
      "XV_GAMMA" (range 100 to 10000)
              client settable attribute
              client gettable attribute (current value is 1000)
      "XV_COLORSPACE" (range 0 to 1)
              client settable attribute
              client gettable attribute (current value is 0)
    maximum XvImage size: 2048 x 2048
    Number of image formats: 4
      id: 0x32595559 (YUY2)
        guid: 59555932-0000-0010-8000-00aa00389b71
        bits per pixel: 16
        number of planes: 1
        type: YUV (packed)
      id: 0x32315659 (YV12)
        guid: 59563132-0000-0010-8000-00aa00389b71
        bits per pixel: 12
        number of planes: 3
        type: YUV (planar)
      id: 0x30323449 (I420)
        guid: 49343230-0000-0010-8000-00aa00389b71
        bits per pixel: 12
        number of planes: 3
        type: YUV (planar)
      id: 0x59565955 (UYVY)
        guid: 55595659-0000-0010-8000-00aa00389b71
        bits per pixel: 16
        number of planes: 1
        type: YUV (packed)

when i run a video with xv enabled (xine/mplayer/vlc), i cant change brightness/contrast, the player shows the change ocurring but nothing is passed over to the xv driver.

using gl2 works fine.

best regards
Comment 1 Alex Deucher 2009-07-06 11:09:08 UTC
xv brightness/contrast/hue/saturation/gamma only work when bicubic filtering is disabled.
xvattr -a XV_BICUBIC -v 0
See the radeon man page.
Comment 2 Paulo Dias 2009-07-06 11:23:02 UTC
(In reply to comment #1)
> xv brightness/contrast/hue/saturation/gamma only work when bicubic filtering is
> disabled.
> xvattr -a XV_BICUBIC -v 0
> See the radeon man page.
> 

thanks for the quick answer, it worked :) can i declare it in xorg.conf? i couldnt find anything in radeon man about it. only at runtime like you said.

best regards
Comment 3 Alex Deucher 2009-07-06 11:35:33 UTC
(In reply to comment #2)
> 
> thanks for the quick answer, it worked :) can i declare it in xorg.conf? i
> couldnt find anything in radeon man about it. only at runtime like you said.

See the XV_BICUBIC section of the man page.  no xorg.conf option for it at the moment.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.