Bug 22682

Summary:	[fixed in git] Rare assertion failure in TpProxyPendingCall when DBusGProxyCall is NULL
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/assertion
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2009-07-09 02:01:27 UTC

commit 87cef643afd5143795871cc7de0b50cd2fde51f5
Author: Simon McVittie <simon.mcvittie@collabora.co.uk>
Date:   2009-07-09 09:53:14 +0100

    TpProxyPendingCall: fix rare crash when cancelled before we've been given our DBusGProxyCall
    
    One of the telepathy-mission-control regression tests hit an assertion
    failure in dbus_g_proxy_cancel_call (., call=0x0), with
    tp_proxy_pending_call_lost_weak_ref on the stack. As far as I can tell,
    this can only happen if the weak_object is finalized before
    tp_proxy_pending_call_v0_take_pending_call is called, which seems unlikely
    but possible.

This happened 2 out of 3 times when running distcheck on MC 5.1.4 (but not when running the tests normally - a timing issue?), and seems to be fixed by using this telepathy-glib build.

Comment 1 Will Thompson 2009-07-09 09:46:27 UTC

This patch looks correct to me; if you're confident that this is the only way that crash can occur, ++.

Comment 2 Simon McVittie 2009-07-20 05:53:01 UTC

Fixed in git but not yet released

Comment 3 Simon McVittie 2009-08-17 04:59:32 UTC

Fixed in 0.7.34

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.