| Summary: | 0.9.2 swfdec_as_object_add_variable prototype mismatch between .h & .c | ||
|---|---|---|---|
| Product: | swfdec | Reporter: | Tim Mooney <Tim.Mooney> |
| Component: | library | Assignee: | swfdec ml <swfdec> |
| Status: | RESOLVED FIXED | QA Contact: | swfdec ml <swfdec> |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | modify the definition to match the prototype in the header file | ||
Created attachment 27776 [details] [review] modify the definition to match the prototype in the header file Thanks, applied to git master. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
In swfdec-0.9.2, the prototype for swfdec_as_object_add_variable in swfdec/swfdec_as_object.h is void swfdec_as_object_add_variable (SwfdecAsObject * object, const char * variable, SwfdecAsFunction * get, SwfdecAsFunction * set, SwfdecAsVariableFlag default_flags); However, in the definition in swfdec_as_object.c, it's void swfdec_as_object_add_variable (SwfdecAsObject *object, const char *variable, SwfdecAsFunction *get, SwfdecAsFunction *set, guint default_flags) The last parameter differs. The Solaris Workshop compiler complains about this and it certainly seems like it's a bug. I've modified the definition to match the declaration from the header file. Trivial patch is attached. (BTW, it might be nice if there were version options available in bugzilla for 0.9, I had to use unspecified). Thanks, Tim