Summary: | Location: update and audit implementation | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
URL: | http://git.collabora.co.uk/?p=user/cassidy/telepathy-gabble;a=shortlog;h=refs/heads/location | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | |||
Bug Blocks: | 22962 |
Description
Simon McVittie
2009-07-27 06:52:39 UTC
This branch updates implementation to fit with latest DRAFT, make the code a bit more robust and improve test coverage. http://git.collabora.co.uk/?p=user/cassidy/telepathy-gabble;a=shortlog;h=refs/heads/location 14:23 < smcv> cassidy: http://git.collabora.co.uk/?p=user/cassidy/telepathy-gabble;a=commitdiff;h=a2ffade26 <- please use exactly-representable floats for regression tests 14:23 < smcv> cassidy: e.g. 1.25 is good, 1.3 is bad 14:29 < smcv> cassidy: also, if countrycode is not in the XEP, probably best not to emit it 14:30 < smcv> cassidy: it's in the Telepathy API for the benefit of protocols that indicate country in an unambiguous non-localized way 14:30 < smcv> cassidy: the idea is that each protocol probably sets either country or countrycode in received geoloc 14:30 < cassidy> smcv: pierlux told me it should be added to the XEP soon 14:30 < smcv> cassidy: oh, if he's actively pushing it, then that's OK 14:31 < smcv> cassidy: clients with geoloc should set both country and countrycode, and the CM will ignore the one it doesn't support, was the general idea 14:32 < smcv> cassidy: so in "good" protocols (that use countrycode), I'll see your country in my locale 14:32 < smcv> cassidy: and in protocols that only have country, I'll see your country in your locale 14:33 < smcv> cassidy: if you're in Belgium and using a French locale, I'd prefer to see "Belgium" rather than "Belgique", on protocols that let me do that Other than that, this looks promising. I didn't work toward getting countrycode added to XEP-80, but I think it should be. As smcv said, countrycode would be the only non localized data in the location information and could prove useful. Guillaume just pointed me where to send such a change request, I'll do that right away. Branch merged. Thanks to Simon for the review. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.