Summary: | Incorrectly #includes <libpurple/foo> rather than <foo> | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Abderaouf M Bencheraiet <kenshin> |
Component: | haze | Assignee: | Telepathy bugs list <telepathy-bugs> |
Status: | RESOLVED MOVED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | minor | ||
Priority: | medium | CC: | kenshin, vine35792468 |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | patch for libpurple headers |
Description
Abderaouf M Bencheraiet
2009-07-31 11:19:20 UTC
this is du to : pkg-config purple --cflags --libs -I/usr/include/libpurple -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -lpurple -lglib-2.0 plus the includes directives in haze for libpurple stuff are in the from #include <libpurpl/xxx.h> Created attachment 30981 [details] [review] patch for libpurple headers Assuming you are not going to try and persuade the libpurple maintainers to change their Cflags in purple.pc from: Cflags: -I${includedir}/libpurple to: Cflags: -I${includedir}/libpurple -I${includedir} which would avoid breaking most other libraries or applications using libpurple, attached is a patch. (It seems unwise to remove the libpurple in <libpurple/*.h> so instead it changes the header includes to <../libpurple/*.h> Could you either get a change to purple.pc or apply the patch please? Chris (In reply to comment #2) > Could you either get a change to purple.pc or apply the patch please? I've just committed a new purple-2.pc file (which will be in libpurple 2.7) which will let Haze do this properly. Haze will have to depend on 2.7 to use it, but that'll be okay: we'll need it for media stuff anyway. I couldn't change the existing .pc file upstream because it would break projects who were including the headers correctly (for some values of correctly). (I'm not sure when libpurple 2.7 will happen...) -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-haze/issues/18. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.