Bug 23079

Summary:	some header files causes gcc warnings
Product:	poppler	Reporter:	Jakub Wilk <jwilk>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	jwilk
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Fix for warnings from poppler/Object.h

Description Jakub Wilk 2009-08-01 06:46:58 UTC

Created attachment 28250 [details] [review]
Fix for warnings from poppler/Object.h

Inclusion of some poppler header files causes gcc to emit dozens of 
warnings. See [1] for an example build log.

Poppler build system suppresses those warnings with -Wno-write-strings. 
I could, of course, use that option too. However, I don't want to 
conceal potential bugs in my own code.

[1] https://buildd.debian.org/fetch.cgi?&pkg=pdf2djvu&ver=0.4.11a-1%2Bb1&arch=i386&stamp=1236513697&file=log

Comment 1 Albert Astals Cid 2009-08-01 07:15:29 UTC

Sorry but won't fix, fixing it brings us nothing else than pain when merging new xpdf releases.

About the pain it creates for you, well, you should not be using internal poppler headers, if you do you have to carry out with the consequences.

Comment 2 Jakub Wilk 2009-08-06 05:30:42 UTC

The patch modifies 2 lines, none of which exist in xpdf sources. How could that possibly make merging more painful?

Comment 3 Albert Astals Cid 2009-08-08 08:27:35 UTC

pushed to git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.