Bug 23163

That patch looks like it will break support for non-NetBSD platforms.  Got a patch that doesn't?

Ideally, we should test for functions like pthread_self by compiling a test program that uses them, not by checking for the specific symbols.  That would improve portability to platforms which work like NetBSD does here.  On the other hand, it wouldn't fix portability to platforms that have different symbols in the pthread library and don't have stubs.  Still seems like an improvement, though.

Created attachment 28396 [details] [review]
find stubs with AC_CHECK_FUNCS and AC_TRY_LINK

I had a big mistake. my first patch break everything.
new patch attached.

new patch use following strategy,

  1. find symbols with AC_CHECK_FUNCS.
  2. if fails, try to compile and link with AC_TRY_LINK

(In reply to comment #3)
> new patch use following strategy,
> 
>   1. find symbols with AC_CHECK_FUNCS.
>   2. if fails, try to compile and link with AC_TRY_LINK

That patch looks much better.  One thing, though: do we really want to bother with AC_CHECK_FUNCS at all?  What advantage does that give us over just using AC_TRY_LINK?  Using AC_TRY_LINK alone would mean we don't have to consider platform-specific details about the implementation of pthread functions (at least, on platforms which *do* provide pthread stubs).

Also, have you tested that the appropriate HAVE_* macros get set in the AC_TRY_LINK case, so that the appropriate stubs go into the library?

Created attachment 28413 [details] [review]
find stubs with AC_TRY_LINK

new patch.
changes from previous:

  * discard AC_CHECK_FUNCS, there is no strong reason to use.
  * treat WITH_* macro

Created attachment 28824 [details] [review]
find stubs with AC_TRY_LINK

patch updated.
changes from previous:

  * separate macro definition to check-stub.m4
  * follow latest codebase. (support sem_* function stubs)

(In reply to comment #6)
> Created an attachment (id=28824) [details]
> find stubs with AC_TRY_LINK
> 
> patch updated.
> changes from previous:
> 
>   * separate macro definition to check-stub.m4
>   * follow latest codebase. (support sem_* function stubs)
> 

Thanks for updating the patch.  I noticed a typo in the new version, though:

+CHECK_SEM_STUB([sem_destory],
+	       [sem_t s; (void)sem_destory(&s);],
+	       [], [lack_stubs=yes])

s/destory/destroy/g

This patch does not apply anymore. There's a chance it's somewhere in NetBSD, could you update it so we can merge this into XCB itself?

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xorg/proto/xcbproto/issues/13.