| Summary: | [fixed in git] telepathy-glib-0.7.33 fails test | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Gilles Dartiguelongue <gilles.dartiguelongue> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | freedesktop-bugs |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/wjt/telepathy-glib.git;a=commitdiff;h=refs/heads/dont-unref-null-message | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | 0001-Do-not-unref-dbus-message-if-it-is-NULL.patch | ||
|
Description
Gilles Dartiguelongue
2009-08-05 14:32:55 UTC
Created attachment 28385 [details] [review] 0001-Do-not-unref-dbus-message-if-it-is-NULL.patch this patch fixes the issue. Most of these are unneeded, because the surrounding code already checks that the message is non-NULL. But one of the dbus_message_unref (reply) calls is in an if (reply == NULL) {} block, which is wrong. The patch at <http://git.collabora.co.uk/?p=user/wjt/telepathy-glib.git;a=commitdiff;h=refs/heads/dont-unref-null-message> should fix it properly; could you check that it works for you?
(In reply to comment #0) > and them a bit later, I also saw something that makes me think the testsuite is > not properly isolated from the system: > > (telepathy-example-no-protocols:15804): tp-glib-DEBUG: started version 0.7.33 > (telepathy-glib version 0.7.31) I assume you're referring to the version discrepancy. That does look odd... (In reply to comment #2) > Most of these are unneeded, because the surrounding code already checks that > the message is non-NULL. But one of the dbus_message_unref (reply) calls is in > an if (reply == NULL) {} block, which is wrong. The patch at > <http://git.collabora.co.uk/?p=user/wjt/telepathy-glib.git;a=commitdiff;h=refs/heads/dont-unref-null-message> > should fix it properly; could you check that it works for you? > it indeed works :) I approve wjt's patch. As for the use of the installed telepathy-glib: are you using an LD_LIBRARY_PATH that contains your system copy of telepathy-glib? LD_LIBRARY_PATH takes precedence over just about everything, so if you are, this may be unavoidable. Failing that, I'd be interested to see how your particular build environment links examples/cm/no-protocols/telepathy-example-no-protocols (the libtool --mode=link command used if you `make clean` and rebuild it). It works correctly for me in git master: smcv@reptile% strings /usr/lib/libtelepathy-glib.so.0 | grep 0.7.33 0.7.33 smcv@reptile% ./examples/cm/no-protocols/telepathy-example-no-protocols (telepathy-example-no-protocols:17431): tp-glib-DEBUG: started version 0.7.33.1 (telepathy-glib version 0.7.33.1) Removing patch kw so this falls out of the review queue. The assertion failure is fixed in 0.7.34. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.