Bug 23251

Summary:	Wrong playlist format key usage in 10-usb-music-players.fdi
Product:	hal	Reporter:	thorsten.klein
Component:	hal-info	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	danny.kukawka
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Fix playlist format key for Meizu M6

Description thorsten.klein 2009-08-11 07:36:31 UTC

Created attachment 28495 [details] [review]
Fix playlist format key for Meizu M6

I had some trouble getting my Meizu M6 working with Rhythmbox lately, actually it wasn't possible to create playlists in the right format.

I did some debugging of Rhythmbox first and figured out that it reads the key 'portable_audio_player.playlist_formats' for my device from hal and expects an array as values then. I checked out the hal-spec of version 0.5.12 and found 'portable_audio_player.playlist_format' as key only.

Changing 'formats' to 'format' in 10-usb-music-players.fdi made everything running smoothly again (patch attached).

The question seems if this is a general bug to fix in that file or are both forms possible? (In the latter case I'd better file a bug report for Rhythmbox)

System:
Ubuntu 9.04
Kernel: 2.6.28-15-generic #48-Ubuntu SMP Wed Jul 29 08:53:35 UTC 2009 x86_64 GNU/Linux
rhythmbox 0.12.0-0ubuntu4
hal 0.5.12~rc1+git20090403-0ubuntu4
hal-info 20090407-0ubuntu1

Comment 1 Danny Kukawka 2009-08-14 07:10:26 UTC

Thanks for the report. Fixed current git. Check: 

http://cgit.freedesktop.org/~dkukawka/hal-info/log/

commit cc0fb7c3d23779f17e2cf1da069c80abf614396e
Author: Danny Kukawka <danny.kukawka@web.de>
Date:   Fri Aug 14 16:05:58 2009 +0200

    s/playlist_formats/playlist_format/

    Fix invalid keyname as pointed out in fd.o#23251:
    - s/playlist_formats/playlist_format/

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.