| Summary: | Please support Chiasmus key files and encrypted files | ||
|---|---|---|---|
| Product: | shared-mime-info | Reporter: | Helge Kreutzmann <debian> |
| Component: | freedesktop.org.xml | Assignee: | Shared Mime Info group <shared_mime_info> |
| Status: | RESOLVED MOVED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | CC: | daniel.leidert.spam, debian |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
A sample file encrypted with Chiasmus
proposed patch A sample chiasmus key Updated patch to the proposed one by Daniel Leidert Updated patch to the one from Daniel (2nd try) |
||
|
Description
Helge Kreutzmann
2009-08-11 09:39:21 UTC
Created attachment 32905 [details] [review] proposed patch The attached patch adds the MIME types application/x-chiasmus-encrypted and application/x-chiasmus-key based on the information in the report. Missing a test file, and an entry in the test suite. I already added a sample file to the report, what kind of "test file" is required? (In reply to comment #3) > I already added a sample file to the report, what kind of "test file" is > required? You need both an xsi and an xia file in the test suite, and you need to add them to tests/list. See the HACKING file for details. Created attachment 40746 [details]
A sample chiasmus key
A sample key as requested (containing one comment)
(In reply to comment #4) > (In reply to comment #3) > > I already added a sample file to the report, what kind of "test file" is > > required? > > You need both an xsi and an xia file in the test suite, and you need to add > them to tests/list. See the HACKING file for details. I now uploaded an sample key (.xis). Unfortunately I don't know what kind of test suite of HACKING you are refering to. As stated in my original bug report, I was asked by David Faure from KDE to file the bug here, I have (not yet) done more that that and it would be great if you could apply the necessary changes (I can provide you additional information as needed, of course). The HACKING file is here: http://cgit.freedesktop.org/xdg/shared-mime-info/tree/HACKING#n31 And it has explanations on how to add files to the test suite. Created attachment 89288 [details]
Updated patch to the proposed one by Daniel Leidert
Hello Bastien, I tried to understand the format of the file you specified. Given my limited understanding (I mainly want konqueror to detect these files, cf. the initial description) I believe the following two lines should suffice: Examplekey.xis application/x-chiasmus-key ooo VTestdatei.pdf.xia application/x-chiasmus-encrypted ooo I applied Daniels patch from Comment1, ran autogen.sh and make freedesktop.org.xml The make command gave errors and I updated the patch (which I attached to this report). However, even then test-mime-data does not really produce sensible results (to me). Now I ran make in the top level directory of shared-mime-info. Using the settings for test/lists given above I get as output: Examplekey.xis, 'name' test: expected application/x-chiasmus-key, got application/octet-stream Examplekey.xis, 'data' test: expected application/x-chiasmus-key, got text/plain Examplekey.xis, 'file' test: expected application/x-chiasmus-key, got text/plain Is that ok? I would be glad if you could query me about the missing information (especially those which you cannot find in the bug log) and update the relevant files yourself. I'm really guessing now whats to be done / updated. Thanks! Created attachment 89289 [details] [review] Updated patch to the one from Daniel (2nd try) I noticed another typo in the patch from Daniel. Please consider the latest one (from 20:48 UTC). Now make in the top directory of shared-mime-info no longer complains, i.e. I think it looks fine. (But please verify) It would be great if you could integrate the patch, the test files and the updated tests/list in your repository. Thanks! -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xdg/shared-mime-info/issues/72. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.