Bug 23295

Summary: nouveau KMS: null pointer dereference if native mode is not found
Product: xorg Reporter: Anssi Hannula <anssi>
Component: Driver/nouveauAssignee: Nouveau Project <nouveau>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
kernel log of native_mode null pointer dereference none

Description Anssi Hannula 2009-08-13 14:52:59 UTC 
When native mode is not found by KMS, at least with NV40, there is a null pointer dereference of native_mode in nv_output_mode_fixup() when starting X.

Kernel log attached.

(In this case native mode is not found because of "Output script table version 0x11 unknown"; I'll open a separate bug for that with proper info if none is already open)
Comment 1 Anssi Hannula 2009-08-13 14:54:13 UTC 
Created attachment 28607 [details]
kernel log of native_mode null pointer dereference
Comment 2 Ben Skeggs 2009-08-13 15:14:14 UTC 
The output script table messages are harmless, and not the cause of your issue.
Comment 3 Anssi Hannula 2009-08-13 15:20:24 UTC 
Ok. Should I still open a bugreport for the fact that the native mode is not found, with vbios dumps etc?
I'd consider this report to be about the missing failure path here, not the fact that it fails :)
Comment 4 Anssi Hannula 2009-08-14 09:22:11 UTC 
drm_edid.c ignores detailed timings on EDID < 1.3, and this LVDS has 1.2, causing no modes found, triggering this issue.
I'll report the EDID parsing one separately elsewhere, as it is a non-nouveau issue.
Comment 5 Anssi Hannula 2009-08-20 17:24:45 UTC 
The EDID parsing issue has been fixed in drm git.

As for this bug, I sent a patch to nouveau mailinglist some days ago, it is awaiting review. "drm/nv04: fix null pointer dereferences of native_mode"
Comment 6 Francisco Jerez 2009-09-17 04:16:01 UTC 
(In reply to comment #5)
> The EDID parsing issue has been fixed in drm git.
> 
> As for this bug, I sent a patch to nouveau mailinglist some days ago, it is
> awaiting review. "drm/nv04: fix null pointer dereferences of native_mode"
> 

It's already pushed so I'm marking this as fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.