Bug 23349

Summary:	telepathy-gabble-0.7.31: 'struct sockaddr_storage' declared inside parameter list
Product:	Telepathy	Reporter:	Thomas Klausner <tk>
Component:	gabble	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	x86-64 (AMD64)
OS:	NetBSD
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch fixing the problem.

Description Thomas Klausner 2009-08-16 11:42:36 UTC

Created attachment 28672 [details] [review]
Patch fixing the problem.

gibber-util.c doesn't compile on NetBSD-5.99.15/amd64:

In file included from gibber-util.c:26:
gibber-util.h:29: warning: 'struct sockaddr_storage' declared inside parameter list
gibber-util.h:29: warning: its scope is only this definition or declaration, which is probably not what you want
gibber-util.c:29: warning: 'struct sockaddr_storage' declared inside parameter list
gibber-util.c:30: error: conflicting types for 'gibber_normalize_address'
gibber-util.h:29: error: previous declaration of 'gibber_normalize_address' was here
gibber-util.c: In function 'gibber_normalize_address':
gibber-util.c:34: error: dereferencing pointer to incomplete type
gibber-util.c:34: error: 'AF_INET6' undeclared (first use in this function)
gibber-util.c:34: error: (Each undeclared identifier is reported only once
gibber-util.c:34: error: for each function it appears in.)
gibber-util.c:34: warning: implicit declaration of function 'IN6_IS_ADDR_V4MAPPED'
gibber-util.c:34: error: dereferencing pointer to incomplete type
gibber-util.c:40: error: dereferencing pointer to incomplete type
gibber-util.c:41: error: dereferencing pointer to incomplete type
gibber-util.c:43: error: dereferencing pointer to incomplete type
gibber-util.c:43: error: 'AF_INET' undeclared (first use in this function)
gibber-util.c:44: error: dereferencing pointer to incomplete type
gibber-util.c:45: error: dereferencing pointer to incomplete type

The attached patch fixes the problem.

Comment 1 Simon McVittie 2009-08-24 13:26:29 UTC

Fixed in git along with Bug #23348, thanks.

(For future reference: since this is basically the same bug as Bug #23348 - not including enough header files to get all the stuff we need on NetBSD - a single bug report with a single patch would have made more sense; I combined both of your patches in order to apply them.)

Comment 2 Simon McVittie 2009-08-24 13:27:14 UTC

*** Bug 23348 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.