Bug 2341

Summary:	_cairo_surface_create_pattern misnamed
Product:	cairo	Reporter:	Owen Taylor <otaylor>
Component:	general	Assignee:	Carl Worth <cworth>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	high	CC:	jwatt
Version:	0.9.3
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Owen Taylor 2005-01-20 11:12:27 UTC

The function doesn't actually create a pattern.

See:
http://lists.freedesktop.org/archives/cairo/2005-January/002744.html

For a suggestion for an alternate name and a suggestion for a simple
interface change to make the function return a surface rather than
modifying the pattern passed in.

Comment 1 Owen Taylor 2005-02-06 11:56:45 UTC

This function is now gone from the surface vtable, but there is still
an internal _cairo_gstate_create_pattern() which could use renaming
(and fixing the out-of-date comment above it.)

Comment 2 Carl Worth 2005-03-08 07:46:59 UTC

As part of David Reveman's recent changes, the offending function
has now shrunk down to almost nothing, and has a much more reasonable
name now "_cairo_gstate_pattern_init_copy".

The name may still not be perfect, but it's enough better that I'm
considering this bug resolved.

Comment 3 Carl Worth 2005-08-22 17:15:48 UTC

Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.