Bug 2350

Summary:	All headers installed
Product:	cairo	Reporter:	Owen Taylor <otaylor>
Component:	general	Assignee:	Carl Worth <cworth>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	high	CC:	jwatt
Version:	0.9.3
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	selective header installation patch

Description Owen Taylor 2005-01-21 14:45:03 UTC

Currently Cairo installs all headers on all platforms ... is 
that intentional?

I'd expect to see it like:

if CAIRO_HAS_PS_SURFACE
cairoinclude_HEADERS += cairo_ps.h
endif

(If you require automake-1.7 you can use += like that and simplify
the Makefile.am :-)

Cairo will automatically dist the union of the ifdef branches.

Comment 1 Shawn T. Amundson 2005-01-21 15:16:41 UTC

Created attachment 1730 [details] [review]
selective header installation patch

Comment 2 Shawn T. Amundson 2005-01-21 15:19:26 UTC

The above patch makes header installation selective.  Also, if headers are in
_HEADERS they need not be in _SOURCES; the patch also removes those headers from
_SOURCES.

-Shawn

Comment 3 Carl Worth 2005-01-24 09:11:15 UTC

Thanks for the patch Shawn.

This is now committed to CVS.

Comment 4 Carl Worth 2005-08-22 17:15:06 UTC

Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.