Bug 23579

Summary:	Must allow DBus Properties interface for g-d-u to work
Product:	udisks	Reporter:	James Westby <jw+debian>
Component:	general	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	medium	CC:	jw+debian
Version:	unspecified
Hardware:	Other
OS:	All
URL:	https://launchpad.net/bugs/403192
Whiteboard:
i915 platform:		i915 features:

Description James Westby 2009-08-28 09:53:48 UTC

Hi,

g-d-u will currently fail to work as it relies on
the DBus Properties interface to be available on
dk-disks, but as it is the system bus this must
be explicitly allowed in the configuration.

http://bazaar.launchpad.net/~james-w/ubuntu/karmic/devicekit-disks/fix-403192/revision/14

Thanks,

James

Comment 1 Martin Pitt 2009-08-29 05:22:40 UTC

This was originally filed as https://launchpad.net/bugs/403192, and this patch was confirmed to work.

Comment 2 Martin Pitt 2009-09-16 09:04:28 UTC

Can we please get this applied upstream? It's causing hundreds of crashes.

Comment 3 David Zeuthen (not reading bugmail) 2009-09-18 13:42:05 UTC

Not sure why I'm not seeing this error, maybe it's because I'm using dbus 1.2.16. Anyway, I think we need some more interfaces. I've committed this to master:

+    <allow send_destination="org.freedesktop.DeviceKit.Disks"
+           send_interface="org.freedesktop.DBus.Properties"/>
+    <allow send_destination="org.freedesktop.DeviceKit.Disks"
+           send_interface="org.freedesktop.DBus.Introspectable"/>
+    <allow send_destination="org.freedesktop.DeviceKit.Disks"
+           send_interface="org.freedesktop.DeviceKit.Disks"/>
+    <allow send_destination="org.freedesktop.DeviceKit.Disks"
+           send_interface="org.freedesktop.DeviceKit.Disks.Device"/>

Comment 4 James Westby 2009-09-18 18:08:49 UTC

That's also the version of DBus I am using, and I doubt, and really
hope, that this is not due to DBus versions or distro patching, changing
the default properties of the system bus in that way could potentially
lead to security holes.

Thanks for committing the change.

James

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.