Bug 23628

Summary: macros: Obsolete macro warnings for AC_HELP_STRING
Product: xorg Reporter: Gaetan Nadon <memsize>
Component: Build/ModularAssignee: Gaetan Nadon <memsize>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: trivial    
Priority: lowest CC: alan.coopersmith
Version: gitKeywords: janitor
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
[PATCH] Fix obsolete macro warnings for AC_HELP_STRING none

Description Gaetan Nadon 2009-09-01 06:53:27 UTC 
When running autoreconf -Wall on any configure.ac using XORG_RELEASE_VERSION, the following
warning is emitted:

	configure.ac:34: warning: The macro `AC_HELP_STRING' is obsolete.
	configure.ac:34: You should run autoupdate.
	../../lib/autoconf/general.m4:209: AC_HELP_STRING is expanded from...
	xorgversion.m4:33: XORG_RELEASE_VERSION is expanded from...

Replacing it with AS_HELP_STRING resolves the warning. Using autoconf verison 2.63.

From Autoconf manual:
http://www.gnu.org/software/autoconf/manual/autoconf.html.gz#Obsolete-Macros:
— Macro: AC_HELP_STRING

    Replaced by AS_HELP_STRING (see AS_HELP_STRING). 

Both xorgversion.m4 and xorg-macros.m4.in are affected.
Comment 1 Gaetan Nadon 2009-09-01 06:57:17 UTC 
Created attachment 29073 [details] [review]
[PATCH] Fix obsolete macro warnings for AC_HELP_STRING

 xorg-macros.m4.in |    6 +++---
 xorgversion.m4    |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 2 Peter Hutterer 2009-09-02 23:01:49 UTC 
Pushed as 79c00a5b5c7866fcc4756993cf4bf4eb2234e9de, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.