| Summary: | Don't advertise FT ContactCapability unless contact can stream data | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED MOVED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | minor | ||
| Priority: | lowest | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
If you advertise NS_FILE_TRANSFER that means you support XEP-0096: SI File Transfer. As this XEP uses SI, you are suppose to support XEP-0095: Stream Initiation as well. We could check that the client supports at least one of the bytestream we implement (SOCKS5 and/or IBB) but, in practice, I'm not aware of any client supporting FT and SI but not SOCKS5 or IBB. Furthemore, if we want to be more strict on caps checking we should extensively test interop with other clients. From my experience, some of them don't announce everything they support. This could have be fixed though, I didn't test this since a while. (In reply to comment #1) > If you advertise NS_FILE_TRANSFER that means you support XEP-0096: SI File > Transfer. As this XEP uses SI, you are suppose to support XEP-0095: Stream > Initiation as well. OK, that's reassuring. > We could check that the client supports at least one of the bytestream we > implement (SOCKS5 and/or IBB) but, in practice, I'm not aware of any client > supporting FT and SI but not SOCKS5 or IBB. Based on this, setting a low severity/priority. > Furthemore, if we want to be more strict on caps checking we should extensively > test interop with other clients. From my experience, some of them don't > announce everything they support. This could have be fixed though, I didn't > test this since a while. A valid point; perhaps this should just be fixed by removing the comment, then. -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-gabble/issues/53. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
From my caps-sanity branch: > /* FIXME: should we check for SI, bytestreams and/or IBB too? */ > resource = gabble_presence_pick_resource_by_caps (presence, > gabble_capability_set_predicate_has, NS_FILE_TRANSFER); I think we should check for the actual requirements for file transfer (currently I believe that means bytestreams, SI and either IBB or SOCKS5); otherwise we'll falsely advertise the FT capability for people we'd actually be unable to make a stream to. However, I could be wrong, in which case please close this as INVALID.