| Summary: | use TpDebugSender | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Jonny Lamb <jonny.lamb> |
| Component: | haze | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | cmaiku |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/jonny/telepathy-haze.git;a=shortlog;h=refs/heads/debug | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
Jonny Lamb
2009-09-07 08:50:45 UTC
I reviewed Mike's updated version of this branch.
In haze_debug():
+ domain = g_strdup_printf ("%s/%s", G_LOG_DOMAIN, "haze");
Dupping this for every debug message is unnecessary:
#define LOG_DOMAIN (G_LOG_DOMAIN "/haze")
+ G_LOG_LEVEL_ERROR, /* PURPLE_DEBUG_CRITICAL */
My purple working copy must be really out of date, I can't see any uses of critical. I trust your judgement that criticals are critical enough to crash on. :-)
I've fixed the first issue, rebased to remove some spurious merges from Jonny's history, and merged. It'll be in 0.3.3. Thanks!
commit a3660efd0090f24280a540b1a87015ffdd312b84
Merge: dee146a 31af13f
Author: Will Thompson <will.thompson@collabora.co.uk>
Date: Mon Nov 9 21:11:45 2009 +0000
Merge branch 'debug'
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.