| Summary: | [bisected i915] gnome characters disappear | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | fangxun <xunx.fang> | ||||
| Component: | Driver/intel | Assignee: | Chris Wilson <chris> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||
| Severity: | blocker | ||||||
| Priority: | highest | CC: | chris, cworth, j, zhenyu.z.wang | ||||
| Version: | unspecified | ||||||
| Hardware: | All | ||||||
| OS: | Linux (All) | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Attachments: |
|
||||||
|
Description
fangxun
2009-09-08 21:20:11 UTC
This should be the one zhenyu raised on intel-gfx@. Chris, we are going to build Q3 rc2 tomorrow. It will be great if you could fix this before that time. I've reproduced this using cairo and creating argb32, a8 and a1 glyphs. Only the argb32 glyphs are visible on an i945. commit 1a77ca74bc829e019a06fe9ad559f013054c27ff Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Wed Sep 9 12:09:05 2009 +0100 i915: Restore nearest sampling My recent commit [94fc93] to use the pixel centre for sampling with the i830 broke the i915. This restores the previous sampling coordinates for the i915 whilst preserving the correct coordinates for i830. It works fine. Verified. Chris, thanks for the quick fix. Closing. the fix has been made into 2.8.99.901 The same issue happened on i915 platform with recently driver. With bisect and find it is the following Xf86_video_intel commit caused the problem: commit e581ceb7381e29ecc1a172597d258824f6a1d2d3 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Tue Nov 10 11:14:23 2009 +0000 i915: Use the color channels to pass along solid sources and masks. Instead of allocating and utilising the texture samplers for 1x1R solid sources and masks we can simply use the default diffuse and specular colour channels and adjust the fragment shader appropriately. The big advantage is the reduction in size of batches which should give a good boost to glyph performance, irrespective of the additional boost from using simpler shaders. However, the motivating factor behind the switch is that our use of 1x1 textures turns out to be buggy... So reopen this bug. I can confirm this issue on a Q35 system with xf86-video-intel master and 2.6.32-rc8. It works fine with xf86-video-intel 2.9.1. Chris, can you reproduce this regression? I'm considering this as 2.10 rc1 blocker. (though this is actually a new issue so it's not proper to reopen this old bug. Anyway, the bisect info has been added here) (In reply to comment #9) > Chris, can you reproduce this regression? I'm considering this as 2.10 rc1 > blocker. I only made the commit after verifying that it passed the test cases added after the last failure. Though as the two failure reports from rendercheck show, there is still some confusion along some paths. I'm optimistic that I can resolve those, otherwise we will have to revert back to incorrect rendering of images just to be able to see text. Can you please confirm which versions of the driver and xserver are being tested? (In reply to comment #10) > Can you please confirm which versions of the driver and xserver are being > tested? We use xf86-video-intel master, and server-1.7-branch. This should restore text whilst I try to understand what the actual failure is: commit cfcabc45140d19bfbfa4737c0a11cdbb042d11eb Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Mon Nov 30 13:58:30 2009 +0000 i915: Disable centre-point sampling. I still have no idea how this is triggering failures, but it is. So revert until the problem is solved. Should fix once again: Bug 23803 [bisected i915] gnome characters disappear http://bugs.freedesktop.org/show_bug.cgi?id=23803 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Verified with commit cfcabc45140d19bfbfa4737c0a11cdbb042d11eb. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.