Bug 2385

Summary: DRM sources no longer build since Kernel 2.6.11 RC2
Product: xorg Reporter: Stefan Dirsch <sndirsch>
Component: Server/Ext/GLXAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: high CC: abo, airlied, cbm, eich, mat
Version: 6.8.2   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
p_drmagp.diff none

Description Stefan Dirsch 2005-01-26 13:53:07 UTC 
The DRM sources no longer build since Kernel 2.6.11 RC2: 
 
[...]  
/usr/src/kernel-modules/drm/drm_agpsupport.h:62: error: parse error before '*'  
token  
/usr/src/kernel-modules/drm/drm_agpsupport.h:62: warning: type defaults to  
`int' in declaration of `drm_agp'  
/usr/src/kernel-modules/drm/drm_agpsupport.h:62: warning: data definition has  
no type or storage class  
[...]
Comment 1 Stefan Dirsch 2005-01-26 13:54:09 UTC 
Created attachment 1756 [details] [review]
p_drmagp.diff

Patch, which seems to fix the build problem, but needs discussion first!
Comment 2 Stefan Dirsch 2005-01-26 13:58:16 UTC 
As you might see the patch is simply a copy of the drm_agp_t structure from 
the old include/linux/agp_backend.h.
Comment 3 Dave Airlie 2005-01-26 14:13:00 UTC 
The solution is to add some compatibility hacks to the old non-linux-core code,
I don't really want to keep maintaining the old non-core code, but I'll try and
add a backways compat check to it... 

With the newer kernels, it shouldn't use the drm_agp_t structure at all, the
intermodule stuff will fail as AGP no longer registers the inter module symbol...
Comment 4 Stefan Dirsch 2005-02-07 14:42:33 UTC 
JFYI, 
my patch (https://bugs.freedesktop.org/attachment.cgi?id=1756) does not work 
at all. 
 
kernel logfile:  
---------------  
Jan 27 17:33:36 f73 kernel: [drm] Initialized radeon 1.11.0 20020828 on minor  
0:   
Jan 27 17:33:36 f73 kernel: [drm:radeon_cp_init] *ERROR* radeon_cp_init called  
without lock held  
Jan 27 17:33:36 f73 kernel: [drm:radeon_unlock] *ERROR* Process 15404 using  
kernel context 0  
  
X.Org logfile:  
--------------  
(WW) RADEON(0): [agp] AGP not available  
(EE) RADEON(0): [agp] AGP failed to initialize. Disabling the DRI.  
(II) RADEON(0): [agp] You may want to make sure the agpgart kernel module  
is loaded before the radeon kernel module.
Comment 5 Stefan Dirsch 2005-04-16 12:36:31 UTC 
Meanwhile we switched to the kernel DRM sources. No need to fix this inside 
the X.Org tree.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.