| Summary: | xrx does not build on Mac OS X/*BSD/AIX in X11R6.8.x stable branch | ||||||
|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Torrey T. Lyons <torrey> | ||||
| Component: | App/other | Assignee: | Roland Mainz <roland.mainz> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | blocker | ||||||
| Priority: | high | CC: | daniel, dberkholz, eric, mcnichol, roland.mainz | ||||
| Version: | 6.8.2 | ||||||
| Hardware: | PowerPC | ||||||
| OS: | Mac OS X (All) | ||||||
| Whiteboard: | |||||||
| i915 platform: | i915 features: | ||||||
| Bug Depends on: | 2398 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Torrey T. Lyons
2005-01-26 16:38:58 UTC
Taking bug myself... Torrey: 1. What about putting the #include into a "#ifdef IS_MACOSX ... #endif"-block - would that work ? 2. Does the problem occur with Xorg trunk, too ? (In reply to comment #2) 1. Yes, we can just wrap it as follows if that is best: #ifdef __DARWIN__ #include <sys/stat.h> #endif We use __DARWIN__ in the X.Org tree to specify Darwin-based OSes. I'm surprised no other BSD's have this issue. 2. Miraculously the top of the tree has #include <sys/stat.h> already I just discovered. Perhaps that is correct in general and should just be put into the 6.8 branch. This also hits FreeBSD, see http://tinderbox.anholt.net/tinderbox3/showlog.pl?machine_id=4&logfile=20050126202533.log&page=40 OpenBSD is affected too. I guess only Linux defines the stat struct inside <stdio.h> :( Created attachment 1766 [details] [review] [FIXED_X11R68x] Proposed fix for X11R6.8.x stable branch The patch simply resyncs the X11R6.8.x stable branch with 2005-01-28-trunk to include the MacOSX/*BSD/AIX fixes from CVS HEAD. Torrey/Donnie: Can you verify that the patch fixes your problem, please ? Keep an eye on the anholt-i386-6_8 box at http://tinderbox.anholt.net/tinderbox3/showbuilds.pl?tree=XMonolithic The proposed patch fixes the problem for Mac OS X. Oops, sorry -- didn't realize it was proposed and not committed. Once it gets committed, then check the tinderbox. It's not mine so I can't do anything about it. It seems very much to me xrx has not received sufficient 'soak time' and that the technology is not quite mature enough to be in the branch; I would not expect builds to break this drastically between release candidates, which are supposedly only receiving known-good bugfixes. Were we unable to test this plugin even in HEAD first for some reason? I would argue that this plugin should be removed from the branch until it has been shown to at least build on a decent percentage of architectures and platforms outside of Linux/x86, which it has been proven to not do thus far. I generally take snapshots from the branch and push them to my customers as part of our (testing) packages, but I may have to review this practice if the branch is constantly used as a place for testing new code rather than a platform for pushing stable, well-tested fixes that have soaked in HEAD. *** Bug 2423 has been marked as a duplicate of this bug. *** (In reply to comment #11) > It seems very much to me xrx has not received sufficient 'soak time' and that > the technology is not quite mature enough to be in the branch; I would not > expect builds to break this drastically between release candidates, which are > supposedly only receiving known-good bugfixes. Daniel: Did you actually read the description of the proposed patch and _realise_ that these patches are build bustage fixes from "trunk" ? Unfortunately the bustage fixes were not part of the original XRX patch - but that also applies to the build bustage caused by the Mesa update, the brasillian patch from Debian and other features commited to the release branch... Comment on attachment 1766 [details] [review] [FIXED_X11R68x] Proposed fix for X11R6.8.x stable branch (Forgot to request approval for this, sorry... ;-/) Roland: Sorry, I thought the xrx .c file was lacking an include somewhere; I didn't actually realise that this was caused by the Brazilian locale patches. My bad. Comment on attachment 1766 [details] [review] [FIXED_X11R68x] Proposed fix for X11R6.8.x stable branch Patch approved in the 2005-01-31 Xorg release-wranglers phone call for commit into the X11R6.8.x stable branch. Comment on attachment 1766 [details] [review] [FIXED_X11R68x] Proposed fix for X11R6.8.x stable branch Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- xc/ChangeLog new revision: 1.365.2.142; previous revision: 1.365.2.141 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/xrx/plugin/include/npapi.h,v <-- xc/programs/xrx/plugin/include/npapi.h new revision: 1.2.4.1; previous revision: 1.2 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/xrx/xnest-plugin/XnestDis.c,v <-- xc/programs/xrx/xnest-plugin/XnestDis.c new revision: 1.2.4.2; previous revision: 1.2.4.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... Patch checked-in... ... marking bug as FIXED (please reopen if there are any build issues left). (In reply to comment #4) > This also hits FreeBSD, see > http://tinderbox.anholt.net/tinderbox3/showlog.pl?machine_id=4&logfile=20050126202533.log&page=40 The tinderbox ("anholt-i386-6_8") switched to "GREEN" again few hours ago... |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.