Bug 2403

Summary:	cairo_set_target_drawable() should take visual/colormap
Product:	cairo	Reporter:	Owen Taylor <otaylor>
Component:	general	Assignee:	Carl Worth <cworth>
Status:	RESOLVED FIXED	QA Contact:	cairo-bugs mailing list <cairo-bugs>
Severity:	normal
Priority:	high	CC:	jwatt
Version:	0.9.3
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Owen Taylor 2005-01-27 15:11:42 UTC

Just a reminder that cairo_set_target_drawable() is badly broken
because it doesn't take a visual/colormap, so it isn't safe for
apps that override colormaps, use multiple screens, etc.

I think there are enough other complexities in using Xlib to write a Cairo
application that requiring the visual and colormap to be passed in
shoudn't be a big burden.

I'm not sure if a cairo_set_target_drawable() or cairo_set_target_xlib()
is actually a good idea... there need to be multiple variants of 
cairo_xlib_surface_create() (with Visual/Colormap or Cairo format. 
With a pixmap/size. For a window without a variable size.) Echoing
this all into cairo_set_target_xlib() variants seem excessive.

Comment 1 Carl Worth 2005-05-10 20:55:22 UTC

The cairo_set_target_drawable function no longer exists.

And its replacements, (the various cairo_xlib_surface_create functions) have
interfaces that require a Visual* where necessary.

In other words, this has all been fixed. (And Owen did all the work.)

Comment 2 Carl Worth 2005-08-22 17:15:54 UTC

Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.