Bug 24067

Summary: Doesn't set the Secret flag on passwords
Product: Telepathy Reporter: Guillaume Desmottes <guillaume.desmottes>
Component: hazeAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: major    
Priority: medium CC: jonathanr.pritchard+bugzilla, smcv
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/haze-smcv.git;a=shortlog;h=refs/heads/secret
Whiteboard:
i915 platform: i915 features:

Description Guillaume Desmottes 2009-09-21 13:48:40 UTC
I was wondering why MC didn't move my facebook password to gnome-keyring. It seems that's because the 'password' param doesn't have the Secret flag. A quick look in telepathy-inspector seems to show that all the protocols have this issue.
Comment 1 Simon McVittie 2009-10-23 06:02:17 UTC
When I filed Bug #24560 I was too annoyed to look for duplicates first...

> telepathy-glib and telepathy-qt4 currently work around old CMs by assuming that
> parameters matching /(^|-)password$/ are passwords, and hence should have the
> SECRET flag.
>
> They shouldn't need to do this; the SECRET flag has existed since
> telepathy-spec 0.17.2 and telepathy-glib 0.7.5.
>
> As a bonus, I also fixed some configure.ac trivia in the referenced branch.
Comment 2 Simon McVittie 2009-10-23 06:02:27 UTC
*** Bug 24560 has been marked as a duplicate of this bug. ***
Comment 3 Simon McVittie 2009-10-23 06:04:20 UTC
On closer inspection of the SILC defaults as they appear in Empathy, private-key should not in fact be a secret, because it is the name of a file that contains the actual private key.
Comment 4 Jonny Lamb 2010-01-25 07:50:13 UTC
I merged and released this in 0.3.3.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.