Summary: | cairo.m4 for autoconf checks | ||
---|---|---|---|
Product: | cairo | Reporter: | Jason Dorje Short <jdorje> |
Component: | general | Assignee: | Carl Worth <cworth> |
Status: | RESOLVED NOTABUG | QA Contact: | cairo-bugs mailing list <cairo-bugs> |
Severity: | enhancement | ||
Priority: | high | CC: | jwatt |
Version: | 0.9.3 | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | Cairo m4 file (version 1) |
Description
Jason Dorje Short
2005-01-28 23:23:15 UTC
Created attachment 1783 [details]
Cairo m4 file (version 1)
What advantage would this have over using the standard pkg-config macro: PKG_CHECK_MODULES(CAIRO, cairo) From your description, it sounds like it has the same functionality. It sounds like PKG_CHECK_MODULES does provide the same functionality. I've never seen this macro before (I'm surprised that gtk and glib m4 files don't use it, but maybe I just have out-of-date m4 files). I'd recommend against including such a .m4 file. We just saw an obscure bug in Pango that occurred because it was finding the wrong version of glib-2.0.m4. The glib and GTK+ m4 files predate pkg-config and are mostly there for compatibility. They also do some extra checks to try and make sure that the version of GTK+/GLib found is the right one, but they don't seem to be effective; I still get lots of Pango bug reports from mixed glib versions. It sounds like we're all happy with PKG_CHECK_MODULES as opposed to a cairo-specific macro. One additional reason to prefer this is that a cairo-specfic macro would give an unhelpful error message, (unrecognized macro or whatever) to anyone trying to build cairo-dependent code from scratch, (as opposed to building from a configure script). I'm closing this bug. Move bugs against "cvs" version to "0.9.3" so we can remove the "cvs" version. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.