|Summary:||[0.8] Time out connection process after a minute|
|Product:||Telepathy||Reporter:||Will Thompson <will>|
|Component:||gabble||Assignee:||Telepathy bugs list <telepathy-bugs>|
|Status:||RESOLVED FIXED||QA Contact:||Telepathy bugs list <telepathy-bugs>|
|i915 platform:||i915 features:|
|Bug Depends on:|
Description Will Thompson 2009-09-24 09:41:59 UTC
If you send <stream:stream ...> to a server, and it never answers, the connection never fails. This can happen if you're on one of those free access points that needs you to sign in with a browser first. My timeout-connect branch against 0.8 fixes this.
Comment 1 Will Thompson 2009-09-24 09:46:08 UTC
Obviously this doesn't apply to 0.9. I don't know how we want to deal with that.
Comment 2 Guillaume Desmottes 2009-09-24 10:10:19 UTC
(In reply to comment #1) > Obviously this doesn't apply to 0.9. I don't know how we want to deal with > that. If we want to add that at a Wocky level, we could add a timer property to the connector or something to tell it it shouldn't wait longer than this value for data from the server.
Comment 3 Alban Crequy 2009-10-05 10:52:17 UTC
You can add a test where the connection fails during the disco request.
Comment 4 Will Thompson 2009-10-05 11:51:51 UTC
(In reply to comment #3) > You can add a test where the connection fails during the disco request. It already exists: test-disco-no-reply.py.
Comment 5 Simon McVittie 2009-10-06 05:50:16 UTC
Python style: using "pass" as the body of a no-op method is conventional. The implementation and test look OK; it's unfortunate that the test will take 9 seconds, though... Perhaps it's time to consider having a CHECK_TWISTED_SLOW flag to enable "slow" tests, like Mission Control does? (Admittedly, that way slow tests wouldn't always be run, which somewhat defeats the object...)
Comment 6 Will Thompson 2009-10-06 12:22:37 UTC
Fixed the Python style issue and merged to telepathy-gabble-0.8. I'll clone the bug for 0.9. For future reference, the range of commits is 8dae59624..6ec61fc8 .