| Summary: | [0.8] Time out connection process after a minute | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Will Thompson <will> |
| Component: | gabble | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/timeout-connect | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 24353 | ||
|
Description
Will Thompson
2009-09-24 09:41:59 UTC
Obviously this doesn't apply to 0.9. I don't know how we want to deal with that. (In reply to comment #1) > Obviously this doesn't apply to 0.9. I don't know how we want to deal with > that. If we want to add that at a Wocky level, we could add a timer property to the connector or something to tell it it shouldn't wait longer than this value for data from the server. You can add a test where the connection fails during the disco request. (In reply to comment #3) > You can add a test where the connection fails during the disco request. It already exists: test-disco-no-reply.py. Python style: using "pass" as the body of a no-op method is conventional. The implementation and test look OK; it's unfortunate that the test will take 9 seconds, though... Perhaps it's time to consider having a CHECK_TWISTED_SLOW flag to enable "slow" tests, like Mission Control does? (Admittedly, that way slow tests wouldn't always be run, which somewhat defeats the object...) Fixed the Python style issue and merged to telepathy-gabble-0.8. I'll clone the bug for 0.9. For future reference, the range of commits is 8dae59624..6ec61fc8 . |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.