Bug 24183

Summary: Several components are including autogen.sh in the distribution tar file
Product: xorg Reporter: Gaetan Nadon <memsize>
Component: Build/ModularAssignee: Gaetan Nadon <memsize>
Status: RESOLVED WONTFIX QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: low CC: alan.coopersmith, peter.hutterer
Version: gitKeywords: janitor
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
[PATCH] font/sun-misc/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] font/adobe-utopia-type1/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] font/mutt-misc/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] xserver/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] app/appres/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] app/xdriinfo/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] app/xcalc/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] app/xwininfo/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] app/editres/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] app/iceauth/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] app/xcursorgen/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] app/xlsfonts/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] app/bitmap/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] proto/damageproto/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] proto/compositeproto/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] lib/libXdmcp/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] driver/xf86-input-void/Makefile.am: do not include autogen.sh in distribution
none
[PATCH] driver/xf86-video-geode/Makefile.am: do not include autogen.sh in distribution none

Description Gaetan Nadon 2009-09-27 11:57:42 UTC 
As described in the INSTALL file, "Briefly, the shell commands `./configure; make; make install' should configure, build, and install this package".

In Makefile.am, the AM_MAINTAINER_MODE macro disables by default the maintainer build rules. If Makefile.am is changed, the make program will not reconfigure the component. Otherwise the package would be reconfigure with different or missing Autotools and could break, making it difficult for anyone to debug.

When the component is built using build.sh or tinderbox, autogen.sh is used which passes the --enable-maintainer-mode option to ./configure. This allows the maintainer to make changes to the configuration and get an automatic rebuild when necessary. 

By shipping autogen.sh we are introducing another build entry point which isn't documented and is confusing. The behavior will also be different as it enables the maintainer build rules.

In font/misc-cyrillic autogen.sh was removed from EXTRA_DIST by Paulo Cesar Pereira de Andrade in http://cgit.freedesktop.org/xorg/font/misc-cyrillic/commit/?id=4cd80d59d8755f43dcaff47f4e281ea4fdf7391b

I'll provide a patch for these components:

font/sun-misc
font/adobe-utopia-type1
font/mutt-misc
xserver
app/appres
app/xdriinfo
app/xcalc
app/xwininfo
app/editres
app/iceauth
app/xcursorgen
app/xlsfonts
app/bitmap
proto/damageproto
proto/compositeproto
lib/libXdmcp
driver/xf86-input-void
driver/xf86-video-geode
Comment 1 Gaetan Nadon 2009-09-27 12:02:30 UTC 
Created attachment 29888 [details] [review]
[PATCH] font/sun-misc/Makefile.am: do not include autogen.sh in distribution
Comment 2 Gaetan Nadon 2009-09-27 12:07:13 UTC 
Created attachment 29889 [details] [review]
[PATCH] font/adobe-utopia-type1/Makefile.am: do not include autogen.sh in distribution
Comment 3 Gaetan Nadon 2009-09-27 12:10:39 UTC 
Created attachment 29890 [details] [review]
[PATCH] font/mutt-misc/Makefile.am: do not include autogen.sh in distribution
Comment 4 Gaetan Nadon 2009-09-27 12:19:20 UTC 
Created attachment 29891 [details] [review]
[PATCH] xserver/Makefile.am: do not include autogen.sh in distribution
Comment 5 Gaetan Nadon 2009-09-27 12:29:21 UTC 
Created attachment 29892 [details] [review]
[PATCH] app/appres/Makefile.am: do not include autogen.sh in distribution
Comment 6 Gaetan Nadon 2009-09-27 12:35:08 UTC 
Created attachment 29893 [details] [review]
[PATCH] app/xdriinfo/Makefile.am: do not include autogen.sh in distribution
Comment 7 Gaetan Nadon 2009-09-27 12:40:39 UTC 
Created attachment 29894 [details] [review]
[PATCH] app/xcalc/Makefile.am: do not include autogen.sh in distribution
Comment 8 Gaetan Nadon 2009-09-27 12:42:46 UTC 
Created attachment 29895 [details] [review]
[PATCH] app/xwininfo/Makefile.am: do not include autogen.sh in distribution
Comment 9 Gaetan Nadon 2009-09-27 12:45:24 UTC 
Created attachment 29896 [details] [review]
[PATCH] app/editres/Makefile.am: do not include autogen.sh in distribution
Comment 10 Gaetan Nadon 2009-09-27 12:58:00 UTC 
Created attachment 29897 [details] [review]
[PATCH] app/iceauth/Makefile.am: do not include autogen.sh in distribution
Comment 11 Gaetan Nadon 2009-09-27 13:05:28 UTC 
Created attachment 29899 [details] [review]
[PATCH] app/xcursorgen/Makefile.am: do not include autogen.sh in distribution
Comment 12 Gaetan Nadon 2009-09-27 13:07:40 UTC 
Created attachment 29900 [details] [review]
[PATCH] app/xlsfonts/Makefile.am: do not include autogen.sh in distribution
Comment 13 Gaetan Nadon 2009-09-27 13:11:28 UTC 
Created attachment 29901 [details] [review]
[PATCH] app/bitmap/Makefile.am: do not include autogen.sh in distribution
Comment 14 Gaetan Nadon 2009-09-27 13:15:08 UTC 
Created attachment 29902 [details] [review]
[PATCH] proto/damageproto/Makefile.am: do not include autogen.sh in distribution
Comment 15 Gaetan Nadon 2009-09-27 13:27:57 UTC 
Created attachment 29903 [details] [review]
[PATCH] proto/compositeproto/Makefile.am: do not include autogen.sh in distribution
Comment 16 Gaetan Nadon 2009-09-27 13:30:06 UTC 
Created attachment 29904 [details] [review]
[PATCH] lib/libXdmcp/Makefile.am: do not include autogen.sh in distribution
Comment 17 Gaetan Nadon 2009-09-27 13:33:01 UTC 
Created attachment 29905 [details] [review]
[PATCH] driver/xf86-input-void/Makefile.am: do not include autogen.sh in distribution
Comment 18 Gaetan Nadon 2009-09-27 13:35:04 UTC 
Created attachment 29906 [details] [review]
[PATCH] driver/xf86-video-geode/Makefile.am: do not include autogen.sh in distribution
Comment 19 Gaetan Nadon 2009-12-01 18:09:15 UTC 
No consensus on this. No action taken.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.