Bug 24259

Summary:	Incorrect check for WIN32 in GooMutex
Product:	poppler	Reporter:	Kovid Goyal <kovid>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	All instances of WIN32 (except cmake related) converted

Description Kovid Goyal 2009-10-01 10:28:25 UTC

Patch 

index f78a14b..6b46fad 100644
--- a/goo/GooMutex.h
+++ b/goo/GooMutex.h
@@ -22,7 +22,7 @@
 // ...
 // gDestroyMutex(&m);

-#ifdef WIN32
+#ifdef _WIN32

 #include <windows.h>

See http://msdn.microsoft.com/en-us/library/b0084kay(VS.80).aspx

Comment 1 Albert Astals Cid 2009-10-01 15:43:18 UTC

If seems we use WIN32 instead of _WIN32 in lots of places, as it seems you have a proper windows test system can you please patch and test them all?

Comment 2 Kovid Goyal 2009-10-01 17:02:56 UTC

Created attachment 29989 [details] [review]
All instances of WIN32 (except cmake related) converted

Compiles and runs pdftohtml and pdftoppm correctly with Visual Studio 2008 (all dependencies also compiled with VS 2008)

Comment 3 Patrick Spendrin 2009-10-04 15:20:42 UTC

for more information: http://stackoverflow.com/questions/662084/whats-the-difference-between-the-win32-and-win32-defines-in-c

Comment 4 Albert Astals Cid 2009-10-04 15:42:16 UTC

Patch commited

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.