Bug 2429

Summary: Wrong prototype for sysarch(2) breaks build on FreeBSD/alpha
Product: xorg Reporter: Dejan Lesjak <dejan.lesjak>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high CC: roland.mainz
Version: git   
Hardware: Alpha   
OS: FreeBSD   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Patch by Greg Lewis none

Description Dejan Lesjak 2005-01-30 20:40:39 UTC 
The prototype in file programs/Xserver/hw/xfree86/os-support/bsd/alpha_video.c:

extern int sysarch(int, char *);

should actually be:

extern int sysarch(int, void *);

It was added to machine/sysarch.h system header in rev. 1.7 about a year ago:
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/alpha/include/sysarch.h
The patch for this was added to ports collection by Greg Lewis (glewis at 
FreeBSD.org):
http://www.freebsd.org/cgi/cvsweb.cgi/ports/x11-servers/XFree86-4-Server/files/
patch-alpha_video.c
for XFree86 port and later for X.Org port:
http://www.freebsd.org/cgi/cvsweb.cgi/ports/x11-servers/xorg-server/files/patch-
alpha_video.c
Diff to current CVS HEAD will be attached. The changed line is only for #ifdef 
__FreeBSD__ case, so it shouldn't affect other operating systems.
Comment 1 Dejan Lesjak 2005-01-30 20:41:47 UTC 
Created attachment 1795 [details] [review]
Patch by Greg Lewis
Comment 2 Roland Mainz 2005-03-02 08:22:40 UTC 
Matthieu:
Is the patch OK for you ?
Comment 3 Eric Anholt 2005-05-09 16:42:34 UTC 
Fix committed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.