Bug 24323

Summary: Standardize pending operations
Product: Telepathy Reporter: Andre Moreira Magalhaes <andrunko>
Component: tp-qtAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/andrunko/telepathy-qt4.git;a=shortlog;h=refs/heads/pending-operations
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 22910    

Description Andre Moreira Magalhaes 2009-10-05 08:57:34 UTC
- Change PendingSuccess/Failure/VoidMethodCall constructors to receive parent as
last param. This is the Qt idiom, and used everywhere in tp-qt4, so let's just change this now.
- Rename PendingVoidMethodCall to PendingVoid. No other pending operation have MethodCall in the name, PendingStringList/PendingVariant for example.
Comment 1 Simon McVittie 2009-10-06 05:27:19 UTC
Fair enough. Ship it, if you feel strongly about this.

My only concern is that if the parent is always the last argument, this makes it harder to have optional arguments at the end. We could use overloaded constructors instead, I suppose...
Comment 2 Andre Moreira Magalhaes 2009-10-06 08:11:47 UTC
Fixed upstream. It will be in next release 0.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.