Bug 24338

Summary:	Should not set the Candidates before accepting the invitation
Product:	Telepathy	Reporter:	Olivier Crête <olivier.crete>
Component:	butterfly	Assignee:	Louis-Francis Ratté-Boulianne <lfrb>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Olivier Crête 2009-10-05 19:17:31 UTC

The SIP engine should only set the candidates on farsight when the users accepts the call and it sends its acceptation to the other side. Otherwise libnice will time out before the call has even started.

Comment 1 Olivier Crête 2009-10-09 16:06:59 UTC

I'm not sure if papyon or butterfly should do it, what happens currently is that:

papyon/media/stream.py:process_remote_description() calls process() which give the remote candidates to the buttefly handler and sets them. This should not happen before the user has accepted. Either butterfly needs to hold onto them until the user accepts, or papyon needs to do it.

Comment 2 GitLab Migration User 2019-12-03 19:44:59 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-butterfly/issues/11.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.