| Summary: | Don't wait for caps if we already know a contact is callable. | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Will Thompson <will> |
| Component: | gabble | Assignee: | Will Thompson <will> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/annie-let%27s-not-wait | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
|
Description
Will Thompson
2009-10-06 05:40:51 UTC
++ from me Merged to 0.8. Care to review http://git.collabora.co.uk/?p=user/wjt/telepathy-gabble-wjt.git;a=shortlog;h=refs/heads/annie-let%27s-not-wait-0.9 too? Also ++, although as bonus work it might be good to use gabble_capability_set_has_one() to test against a canned cap.set in one go. It looks as though you'd need to either make two calls, one with gabble_capabilities_get_any_audio() and one with gabble_capabilities_get_any_video(), or add a gabble_capabilities_get_any_jingle_content() which is the union of those two. Is this blocked in 0.9? (In reply to comment #4) > Is this blocked in 0.9? No, I just forgot to mention that I fixed your review comment. ++ again Merged and released in 0.9.2: commit 9b77f35aa8b054a70ff8e2a5e63a3a61f21a9eb2 Merge: 6d46975 bf56a76 Author: Will Thompson <will.thompson@collabora.co.uk> Date: Thu Oct 22 18:54:26 2009 +0100 Merge branch 'annie-let's-not-wait-0.9' Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.