Bug 2437

Created attachment 1805 [details] [review]
[FIXED_X11R68x] fix for BIOS data reading

Thomas:
Is there anyone who can test the patch and vouch for it (in the next 18h if
possible as we'd like to cut release canidate 4 in this timeframe) ? In todays
release-wranglers call we already approved the last row of patches for the
stable branch and now we're supposed to take only documentation patches (and in
theory very urgend "showstoppers" which do not have workarounds).

Well, erm, I can.... I have actually SEEN this fixing the problem.

PS: This bug can actually be considered a show stopper for, as it seems, a
number of people with new models of laptops/notebooks. In the last week alone,
three people contacted me because of this problem. I am sorry for being so late
with presenting this patch but I found it just recently and needed confirmation
that my fix is proper (which it is, as said).

(In reply to comment #4)
> PS: This bug can actually be considered a show stopper for, as it seems, a
> number of people with new models of laptops/notebooks.

OK, I'll hold off RC2 then for this patch (but no longer than 24h if possible),
either someone vouches for the patch (I'll post a message to the
release-wranglers mailinglist in a few mins) or (better) tests the patch...

> In the last week alone,
> three people contacted me because of this problem. I am sorry for being so 
> late with presenting this patch but I found it just recently and needed

No need to be sorry... better late than having a broken SIS driver in
X11R6.8.2final ... :)

> confirmation that my fix is proper (which it is, as said).

Is it possible that anyone of these people comment here ?

I just wrote an email to one of my testers. I hope he has time to get an account
and add a comment here. Expect something in the lines of "yes, this works".

What this should gain is another question. While I understand the seemingly
assuring "security" that another one's report might provide, please be aware of
the fact that I have actually written this entire driver and you can rest
assured that I do know very well what I am doing ;) Besides, I have received two
confirmations on the patches' (2437+2438) positive effects (one of which
hopefully will be repeated here within the given timeframe).

(In reply to comment #6)
> I just wrote an email to one of my testers. I hope he has time to get an account
> and add a comment here. Expect something in the lines of "yes, this works".
> 
> What this should gain is another question. While I understand the seemingly
> assuring "security" that another one's report might provide, please be aware of
> the fact that I have actually written this entire driver and you can rest
> assured that I do know very well what I am doing ;)

Yes yes, I belive you :) I just want to make sure we don't make any mistake here
because if the patch is in RC4 then we're beyond the point-of-no-return - if
there is anything wrong we likely won't be able to correct that anymore.

(In reply to comment #6)
> please be aware of the fact that I have actually written this entire driver
and you can rest assured that I do know very well what I am doing ;) Besides, I
have received two confirmations on the patches' (2437+2438) positive effects
(one of which hopefully will be repeated here within the given timeframe).

I can confirm that the driver Thomas provided produced clarity far above and
beyond the vesa driver that Fedora Core 3 thought I should use. I believe in the
driver so strongly that I paid him immediately for his work. It's worth every
penny to have sharp lines on my LCD again.

> Is it possible that anyone of these people comment here ?

Thomas said clearly that Testers have confirmed to him that this patch is
working. I don't see why we need a personal testimony from the tester.
Thomas is the only maintainer of this driver and should be trusted on these issues.

(In reply to comment #9)
> > Is it possible that anyone of these people comment here ?
> 
> Thomas said clearly that Testers have confirmed to him that this patch is
> working. I don't see why we need a personal testimony from the tester.
> Thomas is the only maintainer of this driver and should be trusted on these
issues.

The problem is that we're very late in the game and don't have another
release-wranglers phone call to debate the patch. If I just go ahead and approve
the patch I am in trouble as everyone else can demand to get his/her "pet" patch
"in" under the same rule (e.g. same rules for everyone). release-wranglers never
setup a procedure for such emergency stuff so the best thing I can try is to
apply a mozilla.org-style voucher procedure here to avoid further problems...
I just want to be very sure that nothing gets broken and I'd like also have the
barrier slightly bumped via requesting two vouchers for such late patches (I'll
vouch and Kevin Martin vouches and we have a real tester who vouches, too) to
avoid that tons of other non-mandatory stuff hits the tree. RC3 was already bad
enougth as much stuff went in too late... ;-(

Comment on attachment 1805 [details] [review]
[FIXED_X11R68x] fix for BIOS data reading

Approving for commit into X11R6.8.x stable branch (two vouchers: Roland Mainz,
Kevin Martin and one confirmation by Matthew Daniel).

Taking bug myself for commit...

Comment on attachment 1805 [details] [review]
[FIXED_X11R68x] fix for BIOS data reading

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  xc/ChangeLog
new revision: 1.365.2.146; previous revision: 1.365.2.145
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/sis/init301.c,v  <-- 
xc/programs/Xserver/hw/xfree86/drivers/sis/init301.c
new revision: 1.13.2.1; previous revision: 1.13
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...

Patch checked-in into X11R6.8.x stable branch...

... marking bug as FIXED (please reopen if there are any issues left).