Bug 24479

Summary: [REGRESSION] Painless crash in drm_mode_getconnector from "use drm_mode directly for panel modes"
Product: DRI Reporter: Rafał Miłecki <zajec5>
Component: DRM/RadeonAssignee: Default DRI bug account <dri-devel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg from good: 5a9bcacc0a56f0d9577494e834519480018a6cc3
none
fix
none
dmesg from bad: de2103e452ec7f2db5db7c44279735688608381d none

Description Rafał Miłecki 2009-10-12 10:04:32 UTC 
[   51.288993]  [<ffffffffa04b2759>] drm_mode_object_put+0x49/0x80 [drm]
[   51.289048]  [<ffffffffa04b2a34>] drm_mode_destroy+0x24/0x50 [drm]
[   51.289088]  [<ffffffffa04b6e9c>] drm_mode_connector_list_update+0x11c/0x150 [drm]
[   51.289114]  [<ffffffffa04d7ec3>] drm_helper_probe_single_connector_modes+0x113/0x360 [drm_kms_helper]
[   51.289157]  [<ffffffffa04b4e22>] drm_mode_getconnector+0x352/0x380 [drm]
[   51.289199]  [<ffffffffa04a6e3e>] drm_ioctl+0x17e/0x3a0 [drm]
[   51.289236]  [<ffffffffa04b4ad0>] ? drm_mode_getconnector+0x0/0x380 [drm]



[   51.333355]  [<ffffffffa04b2759>] drm_mode_object_put+0x49/0x80 [drm]
[   51.333400]  [<ffffffffa04b2a34>] drm_mode_destroy+0x24/0x50 [drm]
[   51.333443]  [<ffffffffa04b6e9c>] drm_mode_connector_list_update+0x11c/0x150 [drm]
[   51.333473]  [<ffffffffa04d7ec3>] drm_helper_probe_single_connector_modes+0x113/0x360 [drm_kms_helper]
[   51.333520]  [<ffffffffa04b4e22>] drm_mode_getconnector+0x352/0x380 [drm]
[   51.333567]  [<ffffffffa04a6e3e>] drm_ioctl+0x17e/0x3a0 [drm]
[   51.333632]  [<ffffffffa04b4ad0>] ? drm_mode_getconnector+0x0/0x380 [drm]


First bad:

commit de2103e452ec7f2db5db7c44279735688608381d
Author: Alex Deucher <alexdeucher@gmail.com>
Date:   Fri Oct 9 15:14:30 2009 -0400

    drm/radeon/kms: use drm_mode directly for panel modes

    This reduces the number of mode format conversions needed
    and makes native panel mode support cleaner.

    Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>
Comment 1 Rafał Miłecki 2009-10-12 10:08:18 UTC 
Created attachment 30295 [details]
dmesg from good: 5a9bcacc0a56f0d9577494e834519480018a6cc3
Comment 2 Alex Deucher 2009-10-12 10:08:35 UTC 
Created attachment 30296 [details] [review]
fix

I think this patch I posted to dri-devel should do the trick:
http://marc.info/?l=dri-devel&m=125536129219519&w=2
Comment 3 Rafał Miłecki 2009-10-12 10:08:40 UTC 
Created attachment 30297 [details]
dmesg from bad: de2103e452ec7f2db5db7c44279735688608381d
Comment 4 Rafał Miłecki 2009-10-12 10:38:37 UTC 
(In reply to comment #2)
> Created an attachment (id=30296) [details]
> fix
> 
> I think this patch I posted to dri-devel should do the trick:
> http://marc.info/?l=dri-devel&m=125536129219519&w=2

It does, thanks.
Comment 5 Rafał Miłecki 2009-10-12 23:06:16 UTC 
Fixed in drm-next with fb06ca8f8c61dfd7cbfa2092756577ff78a26dcd

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.