Bug 24532

Created attachment 30411 [details]
xserver backtrace

Created attachment 30978 [details] [review]
RandR compat output paranoia

Does this xserver patch fix the crash?

(In reply to comment #2)
> 
> Does this xserver patch fix the crash?
> 

Yes the patch fixes the crash.

What happens now when I startx @ 1280x1024 and disable TV is maximising an xterm gets full screen OK, but xgamma/game gamma don't work and the game still can't get full screen.

By accident I found that all I then need to do to get them to work is just run xrandr - no options needed. After that everything works OK.

(In reply to comment #3)
> What happens now when I startx @ 1280x1024 and disable TV is maximising an
> xterm gets full screen OK, but xgamma/game gamma don't work and the game still
> can't get full screen.

Does the game fail to go fullscreen due to the gamma failure, or something else?

> By accident I found that all I then need to do to get them to work is just run
> xrandr - no options needed. After that everything works OK.

Hmm, sounds like maybe the compat output information isn't (fully) updated when you disable TV, but should be. Then running xrandr again updates it. If that's the case fixing that may make this patch superfluous, but that's going out of my area of expertise.

(In reply to comment #4)
> Does the game fail to go fullscreen due to the gamma failure, or something
> else?

Comparing the outputs of the game in both cases -

 diff et-out-window et-out-full
< XFree86-VidModeExtension: No acceptable modes found
---
> XFree86-VidModeExtension Activated at 1280x1024

> Hmm, sounds like maybe the compat output information isn't (fully) updated when
> you disable TV, but should be. Then running xrandr again updates it. If that's
> the case fixing that may make this patch superfluous, but that's going out of
> my area of expertise.

Yes could be - I guess my original workaround of starting both screens @ 1024x768, diabling TV then xrandr monitor to 1280x1024 maybe only worked because of the xrandr res change.

One thing I forgot to mention about when I do the above, is that when the game quits I end up back @ 1024x768, locked in the bottom right of a 1280x1024 desktop.

This happens with openarena as well - the games are really running at 1280x1024 - I can see that with OSD on my monitor.

So this doesn't seem like a good solution overall. Would be good to get some input from an RandR expert.

(In reply to comment #6)
> So this doesn't seem like a good solution overall. Would be good to get some
> input from an RandR expert.
> 

One caveat - I tried and failed to reproduce the crash with a F12 beta live cd at the weekend. Xserver was 1.7.1 with IIRC -7-fc appended as well.

So now I am paranoid that it could be something to do with me running everything from git in a dir under ~/ while my system xorg is is quite old (7.2).

Though someone on #radeon did report an et crash and I pointed him here for a possible workaround, but didn't hear whether it worked for him.

I am currently running without the patch, so can confirm that an extra run of xrandr does fix both the gamma crash and also stops me getting dumped back in the previous res when games quit.

The crash should be fixed in xserver Git master and will hopefully be backported to the 1.7 branch. The other issues possibly remain but should be tracked in a separate report if necessary.

(In reply to comment #8)
> The crash should be fixed in xserver Git master and will hopefully be
> backported to the 1.7 branch. The other issues possibly remain but should be
> tracked in a separate report if necessary.
> 

Confirmed the segfault is fixed, but the other issues still exist. I'll test some more over the weekend and open a new bug.