Bug 24561

Summary:	[fixed in git] Add SECRET flag to the password, extra-auth-password params
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	rakia	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-sofiasip-smcv.git;a=shortlog;h=refs/heads/trivia
Whiteboard:	fixed in git, will be in 0.5.19
i915 platform:		i915 features:

Description Simon McVittie 2009-10-15 12:49:36 UTC

telepathy-glib and telepathy-qt4 currently work around old CMs by assuming that parameters matching /(^|-)password$/ are passwords, and hence should have the SECRET flag.

They shouldn't need to do this; the SECRET flag has existed since telepathy-spec 0.17.2 and telepathy-glib 0.7.5.

As a bonus, I also fixed a minor build issue in the referenced branch.

Comment 1 Mikhail Zabaluev 2009-11-02 04:23:15 UTC

The changes look good to me.

Comment 2 Simon McVittie 2009-11-02 06:50:42 UTC

Fixed in git, thanks. Please close this bug when you release 0.5.19 (or 0.6.0 if you want to call it that - it's probably about time we have a "stable branch" release of tpsip :-)

Comment 3 Mikhail Zabaluev 2009-12-18 09:51:28 UTC

Released in 0.5.19.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.