Bug 24562

Summary:	Add SECRET flag to the password, *-password params
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	butterfly	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	youness.alaoui
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2009-10-15 12:56:42 UTC

telepathy-glib and telepathy-qt4 currently work around old CMs by assuming that parameters matching /(^|-)password$/ are passwords, and hence should have the SECRET flag.

They shouldn't need to do this; the SECRET flag has existed since telepathy-spec 0.17.2.

Please add the "secret" keyword to all password params in the .manager file, and bitwise-or the SECRET flag into the corresponding bitfield in the result of GetParameters().

As far as I can see this currently affects password, http-proxy-password and https-proxy-password.

Correct .manager syntax:

param-password = s required secret
...
param-http-proxy-password = s secret
...

In GetParameters(), password should have flags = (telepathy.CONN_MGR_PARAM_FLAG_REQUIRED | telepathy.CONN_MGR_PARAM_FLAG_SECRET), and the others should have flags = telepathy.CONN_MGR_PARAM_FLAG_SECRET.

Comment 1 Youness Alaoui 2009-10-26 10:36:38 UTC

Fixed in http://git.collabora.co.uk/?p=user/kakaroto/telepathy-butterfly.git;a=shortlog;h=refs/heads/fix-24562

Also fixes a dbus signature error.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.