| Summary: | Reduce duplication when calling HandleChannels | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | mission-control | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | high | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://git.collabora.co.uk/?p=user/smcv/telepathy-mission-control-smcv.git;a=shortlog;h=refs/heads/undup-handle-channels | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | 24120 | ||
| Bug Blocks: | 23687 | ||
|
Description
Simon McVittie
2009-10-16 06:32:58 UTC
As a bonus, this branch now also fixes computation of UserActionTime (the original branch tried to fix this, but I later discovered that it did it totally wrong, so I rebased the fix into the middle of it), and adds suitable assertions to the regression tests. Might be nice to pull assertEquals from the gabble tests to simplefy some things (obviously not a blocker though) Branch itself looks good :) I do wonder if it won't be easier to review if it had been one big patch to move all the code over instead of 20 small ones (In reply to comment #2) > I do wonder if it won't be easier to review if it had been one big patch to > move all the code over instead of 20 small ones Possibly, but the code for some of the parameters isn't actually trivially equivalent to either of the previous implementations, so I wanted to implement (and test) it a bit at a time, to be able to look at each change in isolation. Fixed in git. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.