|Summary:||[0.9] May call finish_shutdown() twice (and hence crash)|
|Product:||Telepathy||Reporter:||Will Thompson <will>|
|Component:||gabble||Assignee:||Telepathy bugs list <telepathy-bugs>|
|Status:||RESOLVED FIXED||QA Contact:||Telepathy bugs list <telepathy-bugs>|
|i915 platform:||i915 features:|
|Bug Depends on:||24625|
Description Will Thompson 2009-10-19 10:59:57 UTC
When #24625 is fixed, Gabble will call finish_shutdown() several times (once when it moves to Disconnected, and once when its porter_force_close callback fires).
Comment 1 Simon McVittie 2009-10-21 05:42:26 UTC
Looks good. I'd have vaguely prefered the deletion of an unnecessary '\n' to be a separate commit, since it's not actually in the same function or anything.
Comment 2 Will Thompson 2009-10-22 10:55:55 UTC
commit 06a594dabd7fc207ef272a67366d514f21b28afa Author: Will Thompson <firstname.lastname@example.org> Date: Mon Oct 19 18:41:11 2009 +0100 Don't call shut_down() twice on stream errors. This essentially reverts 63d0cd4, which papered over a bug in Wocky where the callback passed to wocky_porter_force_close_async() would never be called in slightly obscure situations. Reviewed-by: Simon McVittie <email@example.com>