Bug 24689

Summary:	tp_list_connection_managers should document that the list of protocols can become invalid
Product:	Telepathy	Reporter:	Guillaume Desmottes <guillaume.desmottes>
Component:	tp-glib	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/cm-trivia
Whiteboard:
i915 platform:		i915 features:

Description Guillaume Desmottes 2009-10-23 04:20:42 UTC

<cassidy> smcv: I understand why I didn't catch https://bugzilla.gnome.org/show_bug.cgi?id=599386 when I fixed the get_protocol crash the other day. The protocol chooser don't call tp_connection_manager_get_protocol but empathy_connection_managers_get_cms which calls tp_list_connection_managers(). The documentation of this function should say that the protocols are not garanteed to say valid :(

<smcv> cassidy: and yeah we should add a _dup version of tp_connection_manager_get_protocol probably, and also comment tp_list_connection_managers, and also deprecate direct access to the CMs' struct fields

Comment 1 Simon McVittie 2010-04-29 08:49:10 UTC

Because I'm working on Protocol objects (which are GObjects with a refcount), I don't want to add any more API for these older protocol structs. Here's a branch which improves the documentation, though - is this enough to close this bug?

Comment 2 Simon McVittie 2010-04-30 06:49:23 UTC

review+ from cassidy, documentation fixes will be in 0.11.5.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.