Bug 24763

Summary: unclear whether there can be duplicate satisfied requests
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: mission-controlAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED MOVED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: minor    
Priority: low    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Simon McVittie 2009-10-27 10:25:07 UTC
From Bug #24120:
> > +    /* collect object paths into a hash table, to drop duplicates */
> > +    for (c = channels; c != NULL; c = c->next)
> > +    {
> > +        const GList *reqs = _mcd_channel_get_satisfied_requests (c->data);
> > +
> >
> > Why would there be duplicate satisfied requests?
>
> Pre-existing problem, I just moved the code. I *believe* that there should
> never be duplicates, because each request is satisfied by at most one channel -
> but beware that McdChannel is sometimes a Channel and sometimes a
> ChannelRequest, so it's non-obvious.
>
> When I refactor MC so McdChannel doesn't exist (long-term goal), this can
> probably start asserting. For now, may I "resolve" this by filing a bug, and
> adding a FIXME comment referencing it?
Comment 1 GitLab Migration User 2019-12-03 19:33:45 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-mission-control/issues/14.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.