Bug 24767

Summary: Vertical green line appears when particular sized video window is off the top of the screen
Product: xorg Reporter: Sitsofe Wheeler <sitsofe>
Component: Driver/intelAssignee: haihao <haihao.xiang>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium CC: chris
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
fix plannar yuv issue
none
fix plannar yuv issue patch backported to 2.11.0 none

Description Sitsofe Wheeler 2009-10-27 12:07:26 UTC 
Description of the problem:
When using gstreamer to play video of a particular size, a vertical green line will appear if the window is dragged off the top of the screen.

(Screenshot: http://launchpadlibrarian.net/34370436/Screenshot.png )

Steps to reproduce:
1. Run
gst-launch-0.10 videotestsrc ! \
'video/x-raw-yuv,width=(int)1156,height=(int)746,framerate=(fraction)25/1,\
format=(fourcc)I420,interlaced=(boolean)false,pixel-aspect-ratio=(fraction)1/1' \
! xvimagesink
.
2. While the video is playing drag the window so that it is partially
of the top of the screen.

Expected result:
Video to keep playing with no artefacts / green lines.

Actual result:
Colours go strange and a vertical green line appears on the left of the video.

How reproducible is the problem?
It is reproducible every time.

Version information:
Ubuntu 9.10 (karmic)
EeePC 900
00:02.1 Display controller: Intel Corporation Mobile 915GM/GMS/910GML Express
Graphics Controller (rev 04)
xorg 1:7.4+3ubuntu7
libdrm-intel1 2.4.14-1ubuntu1
xserver-xorg-video-intel 2:2.9.0-1ubuntu2

Additional information:
This issue does not occur if a composited desktop is used (i.e. compiz is
running). The problem has also been reproduced on Slackware 13.0 on a desktop machine with an Intel G45.

(Originally filed on
https://bugs.launchpad.net/ubuntu/+source/gstreamer0.10/+bug/460677 and then https://bugzilla.gnome.org/show_bug.cgi?id=599679 ).
Comment 1 Carl Worth 2009-11-06 11:44:05 UTC 
Hi Sitsofe,

Thanks for the bug report.

I'm assigning this to haihao.xiang@intel.com since it's specific to video playback.

-Carl
Comment 2 Sitsofe Wheeler 2010-03-08 07:21:01 UTC 
Still here in:

libdrm-intel1 2.4.18-1ubuntu2
xserver-xorg-video-intel

On Ubuntu 10.04 alpha 3.
Comment 3 Sitsofe Wheeler 2010-08-08 06:30:45 UTC 
Still here on
libdrm-intel1 2.4.21+git20100702.b803918f-0ubuntu0sarvatt~lucid
xserver-xorg-video-intel 2:2.12.0+git20100723.0ae30b6d-0ubuntu0sarvatt~lucid
xorg 1:7.5+6ubuntu1~xorgedgers3~lucid
Comment 4 Chris Wilson 2010-09-06 11:36:31 UTC 
It does sound like a decode issue, but it might be worth trying http://cgit.freedesktop.org/~ickle/drm-intel/ drm-intel-next for the overlay fixes. Unless of course you are not using the overlay in that pipeline...
Comment 5 Sitsofe Wheeler 2010-09-07 12:35:02 UTC 
The issue is still here with the stock Ubuntu drivers when using 2.6.36-rc3-00114-g23a0d9e from drm-intel-next. Just as easy to reproduce as ever (so longer as you have gstreamer to hand).
Comment 6 Sitsofe Wheeler 2010-11-15 13:34:36 UTC 
Still here.

intel-next 2.6.37-rc1-00542-g0143832
libdrm-intel1 2.4.22+git20101109.877b2ce1-0ubuntu0sarvatt~lucid
Comment 7 haihao 2010-11-16 22:16:37 UTC 
Created attachment 40321 [details] [review]
fix plannar yuv issue

Could you try with this patch?
Comment 8 Sitsofe Wheeler 2010-11-17 12:33:27 UTC 
Created attachment 40345 [details] [review]
fix plannar yuv issue patch backported to 2.11.0

I had to backport the changes to xorg-x11-drv-intel-2.11.0-5.fc13.x86_64.rpm but the patch resolved the issue on Fedora 13 running on an Intel Corporation 82G965 Integrated Graphics Controller [8086:29a2] (rev 02) which had previously shown the problem.
Comment 9 Chris Wilson 2011-01-19 07:28:05 UTC 
commit 4c4ad555564a80311df1a4b762eb1e119c6d95fb
Author: Xiang, Haihao <haihao.xiang@intel.com>
Date:   Wed Jan 19 15:25:06 2011 +0000

    Correct offset of planes within clipped window
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=24767
    Reported-and-tested-by: Sitsofe Wheeler <sitsofe@yahoo.com>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 10 haihao 2011-01-19 17:38:26 UTC 
Hi,  Chris
     Thank you for committing this patch, but the original patch uses  srcPitch2 not srcPitch,  I don't  think srcPitch is right for this issue.
Comment 11 Chris Wilson 2011-01-20 02:35:12 UTC 
Even better, thanks for checking! ;-)

Do you have commit access to xorg or do you want me to correct it?
Comment 12 haihao 2011-01-20 17:07:26 UTC 
I have pushed a fix for it. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.