Bug 24838

Summary:

Crash inside xf86-video-ati driver while using Banshee 1.6 Beta 2 (1.5.1)

Product:

xorg

Reporter:

Krzysztof A. Sobiecki <sobkas>

Component:

Driver/Radeon

Assignee:

xf86-video-ati maintainers <xorg-driver-ati>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

major

Priority:

medium

Version:

git

Hardware:

x86-64 (AMD64)

OS:

Linux (All)

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
Backtrace	none
My hack(really hacky!) to stop crashes.	none
fallback if no pMaskPicture->pDrawable	none

Description Krzysztof A. Sobiecki 2009-11-01 09:21:38 UTC

Created attachment 30888 [details] [review]
Backtrace

After connecting Sansa e250, it appears inside Banshee window. When I select it inside Banshee window or it switch to it automatically, whole X server crashes. 

I don't think that brand of portable player matters, just something inside Banshee tab causes radeon to crash.
I think, that just touching pMask->pDrawable might cause problems(I don't know).

xserver:d30637339963950910e5f5fb755b8465ac7dddb4
xf86-video-ati:19b4f5f9b647cd470616b8ec1d34f1e4afa357ad
Without KMS, I will check also on KMS.

Comment 1 Krzysztof A. Sobiecki 2009-11-01 09:25:21 UTC

Created attachment 30889 [details] [review]
My hack(really hacky!) to stop crashes.

It's only a small hack, I didn't have time to do something correct.

Comment 2 Krzysztof A. Sobiecki 2009-11-02 02:21:12 UTC

I forgot to mention my graphic card:
OpenGL vendor string: DRI R300 Project
OpenGL renderer string: Mesa DRI R300 (RV530 71C1) 20090101  TCL
OpenGL version string: 1.5 Mesa 7.7-devel

Comment 3 Alex Deucher 2009-11-02 08:07:19 UTC

Created attachment 30917 [details] [review]
fallback if no pMaskPicture->pDrawable

This patch should work around it, but I'm not sure why the driver should be getting an empty mask drawable.

Comment 4 Krzysztof A. Sobiecki 2009-11-02 13:37:59 UTC

Your patch prevent crashes, but I might search for root of this problem(or not depending on available time).

Comment 5 Michel Dänzer 2009-11-05 01:48:51 UTC

(In reply to comment #3)
> Created an attachment (id=30917) [details]
> fallback if no pMaskPicture->pDrawable
> 
> This patch should work around it, but I'm not sure why the driver should be
> getting an empty mask drawable.

A solid or gradient mask could be used for blending the source picture onto the destination picture, e.g.

Patch looks good, please push to master and the 6.12 branch.

Comment 6 Alex Deucher 2009-11-05 07:52:25 UTC

pushed to master and 6.12-branch:
87d7235790866f9c19ef08972d5237f09d940cd9
eab41805c0e6cc6deb7eca9342457b690834d7d2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.