| Summary: | Butterfly fails to advertise Text capabilities | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Olivier Crête <olivier.crete> |
| Component: | butterfly | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | avs, dyerga, xrcalvar |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
This branch should fix the problem http://git.collabora.co.uk/?p=user/olethanh/telepathy-butterfly.git;a=shortlog;h=refs/heads/text_capabilities (In reply to comment #1) > This branch should fix the problem Looks fine, except one thing: add_text_capabilities takes a list of handles. In on_addressbook_contact_added, you give it a single handle. That'll raise an exception saying it can't iterate through a handle. - self.add_text_capabilities(handle) + self.add_text_capabilities([handle]) Other than that, looks fine. I guess you've tested it on the N900? Thanks for the review, I have fixed your remark in my branch. I haven't been able to test is since I haven't got the issue in my n900 but the capabilities show up fine in tp-inspector and Tester said he would test it. Merged in master |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Which makes the N900 not show the "IM using MSN" button on some contacts.. which is fail Nokia-N900-42-10:~# dbus-send --print-reply --dest=org.freedesktop.Telepathy.Connection.butterfly.msn.tester_40tester_2eca /org/freedesktop/Telepathy/Connection/butterfly/msn/tester_40tester_2eca org.freedesktop.Telepathy.Connection.Interface.Capabilities.GetCapabilities array:uint32:54 method return sender=:1.488 -> dest=:1.494 reply_serial=2 array [ struct { uint32 54 string "org.freedesktop.Telepathy.Channel.Type.StreamedMedia" uint32 3 uint32 7 } ] Nokia-N900-42-10:~#