Bug 24899

Summary:	remove MC 5's Account.Interface.Compat
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	mission-control	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	low	CC:	jonny.lamb, vivek
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log/?h=deprecated-compat
Whiteboard:	review+
i915 platform:		i915 features:
Bug Depends on:	49648
Bug Blocks:	24894, 24914
Attachments:	Remove non-standard Compat interface

Description Simon McVittie 2009-11-04 05:33:42 UTC

Maemo 5 uses various extended interfaces beyond what's in telepathy-spec, including those in:

http://git.collabora.co.uk/?p=telepathy-mission-control.git;a=tree;f=xml;hb=master

One of those is Account.Interface.Compat, which includes the "SetHasBeenOnline" method. We should decide whether it makes sense to keep this, and if so, put it in the real spec.

Comment 1 Guillaume Desmottes 2009-11-05 01:59:45 UTC

I think that could make sense or, even better, keep track of the last time the account has been online.

So, when a client detects a connection error he can test if ($last_time_online > $last_time_account_has_been_modified) and give more info to the user: "That's probably  a server or network issue" or "You probably break you account".

This has been suggested in an Empathy bug IIRC.

Comment 2 Will Thompson 2010-06-29 04:17:40 UTC

I'm inclined to think that MC should update this internally.

The Maemo 5 account creation UI signing in the connection behind MC's back to see if it works, then calling this method, is really not good. In a world where we expect MC to manage all connections (which is the world we want to live in) then it will know when accounts have been online, and when that last was.

Comment 3 Simon McVittie 2010-06-29 06:03:26 UTC

(In reply to comment #2)
> I'm inclined to think that MC should update this internally.

It does, and SetHasBeenOnline should just disappear.

Comment 4 Simon McVittie 2010-06-29 06:09:12 UTC

(In reply to comment #1)
> I think that could make sense or, even better, keep track of the last time the
> account has been online.
> 
> So, when a client detects a connection error he can test if ($last_time_online
> > $last_time_account_has_been_modified) and give more info to the user: "That's
> probably  a server or network issue" or "You probably break you account".
> 
> This has been suggested in an Empathy bug IIRC.

If you want this functionality, I think it'd make more sense as a boolean: HasBeenOnlineWithTheseParameters, or some less ugly name for the same :-)

(I'm not sure that this information is enough, though, since regressions in the CM can also cause a connection error, so the CM version is another relevant variable.)

Comment 5 Will Thompson 2010-11-10 09:00:29 UTC

I think we should just bin this.

Comment 6 Simon McVittie 2012-05-08 09:25:52 UTC

Created attachment 61242 [details] [review]
Remove non-standard Compat interface

---

I think we should bin the entire interface. Here's how!

Comment 7 Jonny Lamb 2012-05-09 02:57:35 UTC

Looks good, as long as stuff still works.

Comment 8 Simon McVittie 2012-05-10 12:22:04 UTC

Thanks, fixed in git for 5.13.0

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.