Bug 25058

Summary: [fixed in master] 0.2.0 doesn't compile on Qt >= 4.6beta
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: tp-qtAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-qt4-smcv.git;a=shortlog;h=refs/heads/qvariant-workaround
Whiteboard: fixed in master for 0.3.0
i915 platform: i915 features:

Description Simon McVittie 2009-11-12 10:56:37 UTC
sauron on IRC reports that with Qt 4.6 beta,

../TelepathyQt4/types.h: In function ‘bool operator==(const QDBusVariant&, const QDBusVariant&)’:
../TelepathyQt4/types.h:102: error: redefinition of ‘bool operator==(const QDBusVariant&, const QDBusVariant&)’
/usr/include/qt4/QtDBus/qdbusextratypes.h:177: error: ‘bool operator==(const QDBusVariant&, const QDBusVariant&)’ previously defined here

18:34 < smcv> sauron: that's a workaround for functionality missing from some 
              Qt versions (but apparently not yours)
18:34 < smcv> sauron: it's meant to not be compiled if it's not needed... seems 
              that's not working for you
...
18:40 < smcv> hmm. so HAVE_QDBUSVARIANT_OPERATOR_EQUAL *is* defined
18:41 < smcv> sauron: argh! of course, the ifndef doesn't work, because types.h 
              can't safely include config.h
Comment 1 Simon McVittie 2009-11-12 11:00:52 UTC
This still fails to compile with --disable-Werror; it's not just a warning that becomes fatal in development builds. See "URL" field for proposed patch.
Comment 2 Simon McVittie 2009-11-13 09:19:53 UTC
The next release, probably called 0.3.0, will fix this using the patch I proposed. We'll close this bug when the release is made.
Comment 3 Simon McVittie 2010-01-12 03:46:16 UTC
Actually fixed in 0.2.1.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.