| Summary: | Renaming interface: finally undraft (or delete) | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-spec | Assignee: | Guillaume Desmottes <guillaume.desmottes> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | low | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 23148, 70382 | ||
| Attachments: |
[spec master] Call Renaming a stable API
[spec next] Renaming: emit new identifier in Renamed signals [idle master 1/3] Require telepathy-glib 0.23 [idle master 2/3] Sync constants from Gabble master [idle master 3/3] Use telepathy-glib 0.23 for Renaming interface |
||
|
Description
Simon McVittie
2009-11-17 10:21:39 UTC
Let's just undraft it. Created attachment 87465 [details] [review] [spec master] Call Renaming a stable API The current version is identical to what's in telepathy-idle, which has had it without implementation changes since 2007. If that's not stable API, nothing is :-) I deliberately haven't called it Renaming1 (although I will in the 'next' branch), so that in the unlikely event that any UI pays attention to it, it won't need changes. Not only is Renaming older than the Foo1 convention, it's also older than the Foo.DRAFT convention, so it never had either. (Still to be done: make Idle use it.) ++ Merged to spec master, still needs to land in tp-glib and Idle. Created attachment 87614 [details] [review] [spec next] Renaming: emit new identifier in Renamed signals As a general design principle, signals that announce a new handle should announce its identifier too. This lets client libraries construct a TpContact, Tp::Contact etc. without a round trip. --- I think this blocks having any meaningful high-level API for Renaming. It doesn't seem worth breaking D-Bus API in 0.x for this, but let's fix it in next at least. Comment on attachment 87614 [details] [review] [spec next] Renaming: emit new identifier in Renamed signals Review of attachment 87614 [details] [review]: ----------------------------------------------------------------- ++ (In reply to comment #5) > Merged to spec master, still needs to land in tp-glib and Idle. + Empathy Created attachment 88720 [details] [review] [idle master 1/3] Require telepathy-glib 0.23 Created attachment 88721 [details] [review] [idle master 2/3] Sync constants from Gabble master Created attachment 88722 [details] [review] [idle master 3/3] Use telepathy-glib 0.23 for Renaming interface Comment on attachment 88720 [details] [review] [idle master 1/3] Require telepathy-glib 0.23 Review of attachment 88720 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 88721 [details] [review] [idle master 2/3] Sync constants from Gabble master Review of attachment 88721 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 88722 [details] [review] [idle master 3/3] Use telepathy-glib 0.23 for Renaming interface Review of attachment 88722 [details] [review]: ----------------------------------------------------------------- ++ Fixed in telepathy-glib 0.23.0, idle 0.3.0 Still needs adding to telepathy-glib 'next'. (In reply to comment #16) > Still needs adding to telepathy-glib 'next'. Appears to have been done, but idle-next doesn't take advantage of that. Guillaume, could you finish that off please? (Merging from master might be enough) (In reply to comment #17) > (In reply to comment #16) > > Still needs adding to telepathy-glib 'next'. > > Appears to have been done, but idle-next doesn't take advantage of that. > Guillaume, could you finish that off please? (Merging from master might be > enough) Done; I merged master into next. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.